Skip to content

Conversation

@shaikhu
Copy link
Contributor

@shaikhu shaikhu commented Jun 25, 2024

According to the docs, since v1.5 the Tools format has been deprecated and a new format recommended. While the entity Metada has been updated to use the new format (new method setToolChoice), Vulnerability has not. This PR adds a similar method to Vulnerability.

@shaikhu shaikhu requested a review from a team as a code owner June 25, 2024 09:12
@nscuro nscuro added the enhancement New feature or request label Jun 25, 2024
@codacy-production
Copy link

codacy-production bot commented Jun 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.71% 97.83%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (16276f9) 6052 4452 73.56%
Head commit (16a7cce) 6282 (+230) 4666 (+214) 74.28% (+0.71%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#438) 276 270 97.83%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@shaikhu shaikhu requested a review from nscuro July 8, 2024 15:22
Signed-off-by: Usman Shaikh <[email protected]>
Signed-off-by: Usman Shaikh <[email protected]>
Signed-off-by: Usman Shaikh <[email protected]>
Signed-off-by: Usman Shaikh <[email protected]>
@shaikhu shaikhu requested a review from mr-zepol September 7, 2024 13:43
@mr-zepol
Copy link
Contributor

@shaikhu new fields were introduced to the vulnerability class, so you might need to rebase and add them to the serializer you are creating

@shaikhu shaikhu requested a review from mr-zepol September 19, 2024 08:25
Copy link
Contributor

@mr-zepol mr-zepol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, I can run some tests after is merged and if I find something I can check with @shaikhu

@mr-zepol
Copy link
Contributor

@nscuro are we okay to merge this one?

Signed-off-by: Alexander Alzate <[email protected]>
@nscuro nscuro added this to the 10.0.0 milestone Nov 28, 2024
@nscuro nscuro merged commit 256b719 into CycloneDX:master Nov 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants