GO-2278: streamline docker setup and update documentation #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker setup here is not complex enough to warrant docker-compose files, so this commit removes them in favor of simple `docker build` and `docker run` commands. The other change here is to the docker image version specified. It is too easy to forget to change the hard-coded version when we update our support window. We have changed our new version support process a lot since we last updated the version here. We now tend to support new Go releases very soon after they release, so I think we can get away with having the default version be `latest` in our Dockerfiles. This commit updates the documentation to match both the above changes and changes made to teamserver.
mark-pictor-csec
suggested changes
May 15, 2025
Contributor
mark-pictor-csec
left a comment
mark-pictor-csec
left a comment
There was a problem hiding this comment.
After looking at the commit changing from latest, I do think we need to change this - so changing my review from comment to request changes.
mark-pictor-csec
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker setup here is not complex enough to warrant docker-compose files, so this commit removes them in favor of simple
docker buildanddocker runcommands.The other change here is to the docker image version specified. It is too easy to forget to change the hard-coded version when we update our support window. We have changed our new version support process a lot since we last updated the version here. We now tend to support new Go releases very soon after they release, so I think we can get away with having the default version be
latestin our Dockerfiles.This commit updates the documentation to match both the above changes and changes made to teamserver.