Revert "Update earliest available data column slot after pruning" #10318
+3
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit af9bc3b.
2 tasks
zilm13
approved these changes
Feb 3, 2026
| public class FinalizedStateCache { | ||
|
|
||
| private static final long MAX_REGENERATE_SLOTS = 10_000L; | ||
| private static final long MAX_REGENERATE_LOTS = 10_000L; |
Contributor
There was a problem hiding this comment.
we keep this, so only reverting?
Contributor
Author
There was a problem hiding this comment.
let change this on another PR, i'd like to leave this as a clean revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10265
As we discussed, there is an unwanted interaction with the new custody backfiller. We need to avoid both classes writing the same variable. It is better to leave the pruner as is and let the backfiller be the only one responsible for updating the variable.
done here: #10312
Note
Medium Risk
Changes data-column sidecar pruning to no longer update the
earliestAvailableDataColumnSlotDB variable, which could affect components relying on that metadata for backfill/custody progress.Overview
Reverts the earlier behavior where data-column sidecar pruning updated the
earliestAvailableDataColumnSlotvariable:KvStoreDatabase.pruneDataColumnSidecarsnow only deletes sidecars and commits, leaving that variable to be managed elsewhere.Removes the integration test that asserted
earliestAvailableDataColumnSlotchanges after pruning, and includes a small internal rename inFinalizedStateCache(MAX_REGENERATE_SLOTS->MAX_REGENERATE_LOTS).Written by Cursor Bugbot for commit 14ea9c8. This will update automatically on new commits. Configure here.