Enable new column backfiller by default and fix DB variable update #10312
+33
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also make the backfiller the only one responsible of writing
earliestAvailableCustodySlotdb variable.see #10318
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes default behavior to enable the reworked column custody backfiller and adjusts how the custody cursor DB value is advanced, which can impact sync/backfill behavior and resource usage on real networks.
Overview
Enables the reworked data-column custody backfiller by default by switching the default for
--Xp2p-reworked-sidecar-custody-sync-enabled(and the underlyingP2PConfigdefault) from disabled to enabled.Fixes
DasCustodyBackfillerso when the storedearliestAvailableCustodySlotis at/behind the movingminCustodyPeriodSlot, it writes the cursor forward tominCustodyPeriodSlotinstead of just exiting, and adds a unit test covering this cursor-alignment case. Acceptance tests are updated to stop explicitly enabling the reworked custody sync, and the changelog notes the backfiller being enabled.Written by Cursor Bugbot for commit 8ba9e1f. This will update automatically on new commits. Configure here.