Skip to content

Remove initial graph log, output is excessive and not useful #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Remove initial graph log, output is excessive and not useful #494

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25a6b3b
Remove initial graph log, output is excessive and not useful
loganintech Sep 30, 2025
4bab008
Log stats about graph if there are cycles.
ggreer Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/sync/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,13 @@ func (s *syncer) SyncGrantExpansion(ctx context.Context) error {
zap.Any("cycle", comps[0]),
zap.Any("scc_metrics", sccMetrics),
)
l.Debug("initial graph", zap.Any("initial graph", entitlementGraph))
l.Debug("initial graph stats",
zap.Int("edges", len(entitlementGraph.Edges)),
zap.Int("nodes", len(entitlementGraph.Nodes)),
zap.Int("actions", len(entitlementGraph.Actions)),
zap.Int("depth", entitlementGraph.Depth),
zap.Bool("has_no_cycles", entitlementGraph.HasNoCycles),
)
if dontFixCycles {
return fmt.Errorf("cycles detected in entitlement graph")
}
Expand Down
Loading