Remove initial graph log, output is excessive and not useful

[loganintech]

Note

Replace verbose entitlement graph debug log with concise stats (edges, nodes, actions, depth, has_no_cycles) during cycle detection.

• Logging:
  • In pkg/sync/syncer.go (SyncGrantExpansion), replace full entitlementGraph debug dump with concise metrics: edges, nodes, actions, depth, and has_no_cycles.

^{Written by Cursor Bugbot for commit 4bab008. This will update automatically on new commits. Configure here.}

Summary by CodeRabbit

• Chores
  • Reduced internal debug log verbosity during entitlement cycle detection to produce cleaner logs and improve signal-to-noise for monitoring. Detection, remediation, and error-handling behavior remain unchanged; no user-facing functionality, performance, stability, or configuration changes.

[coderabbitai]

Walkthrough

Replaces a debug log that dumped the full entitlement graph in SyncGrantExpansion with a debug log that reports discrete graph statistics (edges, nodes, actions, depth, has_no_cycles). No control flow, cycle handling, or exported APIs were changed.

Changes

Cohort / File(s)	Summary
Logging adjustments in SyncGrantExpansion pkg/sync/syncer.go	Replaced a debug log that dumped the entire entitlement graph on cycle detection with a debug log reporting discrete graph statistics (edges, nodes, actions, depth, has_no_cycles). No logic or control flow changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Don't log entire graph #401 — Removed full entitlement-graph dump from SyncGrantExpansion debug logs; closely related logging change.
• If cycles are detected, only log the whole entitlement graph if we're debug logging. #325 — Similar change to initial entitlement-graph logging in SyncGrantExpansion.
• Don't fail all grant expansion if we fail to find a resource. #228 — Related adjustments to SyncGrantExpansion logging and error-handling patterns.

Suggested reviewers

• jirwin

Poem

A rabbit nudged the noisy log,
Swapped the dump for tidy stats,
Quiet hops across the cog,
Same checks, fewer spats.
Commit done — a carrot clap—hop, zap! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly describes the core change—removing the initial graph log due to excessive and unhelpful output—and directly reflects the primary intent of the pull request as outlined in the summary and objectives.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch logan/remove-initial-graph-log

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25a6b3b and 4bab008.

📒 Files selected for processing (1)

• pkg/sync/syncer.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: go-test (1.25.x, windows-latest)

🔇 Additional comments (1)

pkg/sync/syncer.go (1)

1420-1426: Concise statistics log is better than complete removal.

The implementation adds a debug log with discrete graph statistics instead of completely removing logging. This is actually an improvement over both the original verbose dump and complete removal—it provides useful diagnostic information (edge/node counts, depth, cycle detection status) without excessive output.

However, the PR title states "Remove initial graph log" which suggests complete removal, while the implementation replaces it with a more concise version. If this change in approach was intentional, consider updating the PR description to reflect that you're "replacing" rather than "removing" the log.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0cff3bd and 25a6b3b.

📒 Files selected for processing (1)

• pkg/sync/syncer.go (1 hunks)

🧰 Additional context used

🪛 GitHub Check: go-lint

pkg/sync/syncer.go

[failure] 1420-1420:
commentFormatting: put a space between // and comment text (gocritic)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Cursor Bugbot
• GitHub Check: Cursor Bugbot
• GitHub Check: go-test (1.25.x, windows-latest)