`FieldTmp` gather support #2009

psychocoderHPC · 2017-05-03T09:02:06Z

Add an explicit method to trigger that border data from the neighbor is gathered into the local guard of the GPU.

add method asyncCommunicationGather() (gather neighbor's border data)
add buffer for gather communication
define fieldTmpSupportGatherCommunication variable in memory.param to activate gather support for FieldTmp
remove method getCommTag()

Note

Currently the new method asyncCommunicationGather() is only available in FieldTmp but should be later also be ported to all other buffers like FieldE and FieldB. The best way to do this is to extend the PMacc GridBuffer to support asyncCommunicationScatter() and asyncCommunicationGather().
This is a bigger refactoring and should not be part of this pull request to allow a backport to the current release candidate 0.3.0.

psychocoderHPC · 2017-05-03T09:31:59Z

src/picongpu/include/fields/FieldTmp.hpp


+        /** gather data from neighbor GPU
+         *
+         * copy data from the border of neighboring GPU into the local guard.


Add missing information that there is no race condition if asyncCommunicationGather is called before or after asyncCommunication

ax3l

little bug you found yourself and a few little comments for doc strings

ax3l · 2017-05-03T09:34:50Z

examples/Bunch/include/simulation_defines/param/memory.param

+ *
+ * If `true` it is possible to call the method `asyncCommunicationGather()`
+ * to copy data from the border of neighboring GPU into the local guard.
+ */


Add a bit more specific info: "This is also known as building up a "ghost" or "halo" region in domain decomposition and only necessary for specific algorithms that extend the basic PIC cyle, e.g. with dependence on derived density or energy fields."

Ahh I see you tried if I copy&past your text without reading it^^ cyle must be cycle

ax3l · 2017-05-03T09:36:50Z

src/picongpu/include/fields/FieldTmp.hpp

-
        virtual EventTask asyncCommunication( EventTask serialEvent );

+        /** gather data from neighbor GPU


neighboring GPUs

ax3l · 2017-05-03T09:39:44Z

src/picongpu/include/fields/FieldTmp.tpp

+            {
+                /* guarding cells depend on direction
+                 * for negative direction use originGuard else endGuard (relative direction ZERO is ignored)
+                 * don't switch end and origin because this is a read buffer and no send buffer


and not a send buffer

ax3l · 2017-05-03T09:42:36Z

src/picongpu/include/fields/FieldTmp.tpp


+    EventTask FieldTmp::asyncCommunicationGather( EventTask serialEvent )
+    {
+        PMACC_VERIFY_MSG( fieldTmpSupportGatherCommunication == true, "fieldTmpSupportGatherCommunication in memory.param must be set to true" );


make me a two liner

ax3l · 2017-05-03T09:42:54Z

src/picongpu/include/fields/FieldTmp.tpp

+        PMACC_VERIFY_MSG( fieldTmpSupportGatherCommunication == true, "fieldTmpSupportGatherCommunication in memory.param must be set to true" );
+
+        if( fieldTmpRecv != nullptr )
+            m_gatherEv = fieldTmpRecv->asyncCommunication( m_scatterEv + m_gatherEv );


self-found by @psychocoderHPC : serialEvent needs to be handled here

ax3l · 2017-05-03T14:47:11Z

src/picongpu/include/simulation_defines/param/memory.param

+     *
+     * If `true` it is possible to call the method `asyncCommunicationGather()`
+     * to copy data from the border of neighboring GPU into the local guard.
+     */


forgot:

This is also known as building up a "ghost" or "halo" region in domain

decomposition and only necessary for specific algorithms that extend

the basic PIC cycle, e.g. with dependence on derived density or energy fields.

ax3l · 2017-05-03T14:48:07Z

src/picongpu/include/fields/FieldTmp.hpp


-        uint32_t getCommTag();
-
        virtual EventTask asyncCommunication( EventTask serialEvent );


it would make sense to add a doxygen string here now, too

define a variable in `memory.param` to activate gather support for `FieldTmp`

- add method `asyncCommunicationGather()` (gather neighbor border data) - add buffer for gather communication

Adds the following changes to the `release-0.3.0` branch: - Multiple ionizers per species: `ionizer< ... >` became a sequence of `ionizers< ... >` ComputationalRadiationPhysics#1999 - Thomas-Fermi: - fixes in domain decomposition ComputationalRadiationPhysics#2007 - fixes compile issue (missing include) ComputationalRadiationPhysics#2003 - BSI models restructured ComputationalRadiationPhysics#2013 - ADK: fix effective principal quantum number `nEff` ComputationalRadiationPhysics#2011 - multiple ionization algorithms can be applied per species, e.g. cut-off barrier suppression ionization (BSI), probabilistic field ionization (ADK) and collisional ionization ComputationalRadiationPhysics#1999 - FieldTmp: Gather support to fill GUARD ComputationalRadiationPhysics#2009 - Fix undefined device variable in tilted laser pulse ComputationalRadiationPhysics#2017 - CompileTime Accessor: Type (::type) ComputationalRadiationPhysics#1998 - TBG Macros: Outdated Comment ComputationalRadiationPhysics#2004 Increases the state of the `0.3.0` release candidate to `rc3`.

psychocoderHPC added component: core in PIConGPU (core application) feature labels May 3, 2017

psychocoderHPC assigned ax3l May 3, 2017

psychocoderHPC requested a review from ax3l May 3, 2017 09:02

psychocoderHPC force-pushed the topic-fieldTmpGatherComm branch from b704d66 to cabc47f Compare May 3, 2017 09:12

ax3l added this to the 0.3.0: Release Candidate milestone May 3, 2017

psychocoderHPC commented May 3, 2017

View reviewed changes

psychocoderHPC mentioned this pull request May 3, 2017

Buffer gather and scatter support #2010

Open

ax3l requested changes May 3, 2017

View reviewed changes

psychocoderHPC force-pushed the topic-fieldTmpGatherComm branch 2 times, most recently from e6bcf48 to 2c0e2cc Compare May 3, 2017 13:31

ax3l reviewed May 3, 2017

View reviewed changes

ax3l approved these changes May 3, 2017

View reviewed changes

psychocoderHPC added 2 commits May 3, 2017 16:48

add fieldTmpSupportGatherCommunication to param

b358bba

define a variable in `memory.param` to activate gather support for `FieldTmp`

FieldTmp gather support

1c2bbab

- add method `asyncCommunicationGather()` (gather neighbor border data) - add buffer for gather communication

psychocoderHPC force-pushed the topic-fieldTmpGatherComm branch from 2c0e2cc to 1c2bbab Compare May 3, 2017 14:55

ax3l approved these changes May 4, 2017

View reviewed changes

ax3l merged commit cdeae39 into ComputationalRadiationPhysics:dev May 4, 2017

psychocoderHPC deleted the topic-fieldTmpGatherComm branch May 5, 2017 13:06

ax3l mentioned this pull request May 11, 2017

Fixes & Ionizers for 0.3.0-rc3 #2035

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`FieldTmp` gather support #2009

`FieldTmp` gather support #2009

Uh oh!

psychocoderHPC commented May 3, 2017 •

edited by PrometheusPi

Loading

Uh oh!

psychocoderHPC May 3, 2017

Uh oh!

ax3l left a comment

Uh oh!

ax3l May 3, 2017

Uh oh!

psychocoderHPC May 3, 2017

Uh oh!

ax3l May 3, 2017

Uh oh!

ax3l May 3, 2017

Uh oh!

ax3l May 3, 2017

Uh oh!

ax3l May 3, 2017

Uh oh!

ax3l May 3, 2017

Uh oh!

ax3l May 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		virtual EventTask asyncCommunication( EventTask serialEvent );

		/** gather data from neighbor GPU


		uint32_t getCommTag();

		virtual EventTask asyncCommunication( EventTask serialEvent );

FieldTmp gather support #2009

FieldTmp gather support #2009

Uh oh!

Conversation

psychocoderHPC commented May 3, 2017 • edited by PrometheusPi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ax3l left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`FieldTmp` gather support #2009

`FieldTmp` gather support #2009

psychocoderHPC commented May 3, 2017 •

edited by PrometheusPi

Loading