Skip to content

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Apr 27, 2017

little follow-up to #1754 adding a missing include that caused compile issues

little follow-up to ComputationalRadiationPhysics#1754 adding a missing include that caused
compile issues
@ax3l ax3l added bug a bug in the project's code component: core in PIConGPU (core application) labels Apr 27, 2017
@ax3l ax3l added this to the 0.3.0: Release Candidate milestone Apr 27, 2017
@ax3l ax3l requested review from PrometheusPi and n01r April 27, 2017 22:12
Copy link
Member

@PrometheusPi PrometheusPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ax3l If you do not insist in adding your name to the license header, thus looks good to me ans I will merge it

@ax3l
Copy link
Member Author

ax3l commented Apr 28, 2017

that's ok for this file, the change is rather trivial. thanks for reminding, feel free to merge :)

@PrometheusPi PrometheusPi merged commit a47c3a4 into ComputationalRadiationPhysics:dev Apr 28, 2017
@ax3l ax3l deleted the fix-includeTF branch April 28, 2017 09:46
ax3l added a commit to ax3l/picongpu that referenced this pull request May 11, 2017
Adds the following changes to the `release-0.3.0` branch:

- Multiple ionizers per species:
  `ionizer< ... >` became a sequence of `ionizers< ... >` ComputationalRadiationPhysics#1999
- Thomas-Fermi:
  - fixes in domain decomposition ComputationalRadiationPhysics#2007
  - fixes compile issue (missing include) ComputationalRadiationPhysics#2003
- BSI models restructured ComputationalRadiationPhysics#2013
- ADK: fix effective principal quantum number `nEff` ComputationalRadiationPhysics#2011
- multiple ionization algorithms can be applied per species,
  e.g. cut-off barrier suppression ionization (BSI),
  probabilistic field ionization (ADK) and collisional ionization ComputationalRadiationPhysics#1999
- FieldTmp: Gather support to fill GUARD ComputationalRadiationPhysics#2009
- Fix undefined device variable in tilted laser pulse ComputationalRadiationPhysics#2017
- CompileTime Accessor: Type (::type) ComputationalRadiationPhysics#1998
- TBG Macros: Outdated Comment ComputationalRadiationPhysics#2004

Increases the state of the `0.3.0` release candidate to `rc3`.
ax3l added a commit to ax3l/picongpu that referenced this pull request May 11, 2017
Adds the following changes to the `release-0.3.0` branch:

- Multiple ionizers per species:
  `ionizer< ... >` became a sequence of `ionizers< ... >` ComputationalRadiationPhysics#1999
- Thomas-Fermi:
  - fixes in domain decomposition ComputationalRadiationPhysics#2007
  - fixes compile issue (missing include) ComputationalRadiationPhysics#2003
- BSI models restructured ComputationalRadiationPhysics#2013
- ADK: fix effective principal quantum number `nEff` ComputationalRadiationPhysics#2011
- multiple ionization algorithms can be applied per species,
  e.g. cut-off barrier suppression ionization (BSI),
  probabilistic field ionization (ADK) and collisional ionization ComputationalRadiationPhysics#1999
- FieldTmp: Gather support to fill GUARD ComputationalRadiationPhysics#2009
- Fix undefined device variable in tilted laser pulse ComputationalRadiationPhysics#2017
- CompileTime Accessor: Type (::type) ComputationalRadiationPhysics#1998
- TBG Macros: Outdated Comment ComputationalRadiationPhysics#2004

Increases the state of the `0.3.0` release candidate to `rc3`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug a bug in the project's code component: core in PIConGPU (core application)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants