Clam 2588 Record PDF URIs if generating scan metadata#1482
Merged
val-ms merged 2 commits intoCisco-Talos:mainfrom May 31, 2025
Merged
Clam 2588 Record PDF URIs if generating scan metadata#1482val-ms merged 2 commits intoCisco-Talos:mainfrom
val-ms merged 2 commits intoCisco-Talos:mainfrom
Conversation
jhumlick
force-pushed
the
CLAM-2588-PDF-Urls
branch
5 times, most recently
from
344710a to
934eb00
Compare
val-ms
requested changes
Apr 13, 2025
jhumlick
force-pushed
the
CLAM-2588-PDF-Urls
branch
from
b4d3ca0 to
01a0c01
Compare
val-ms
requested changes
May 19, 2025
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
This is great! I just have one concern
jhumlick
force-pushed
the
CLAM-2588-PDF-Urls
branch
7 times, most recently
from
33a8e0e to
46c3aed
Compare
val-ms
changed the title
Threat Research requests scanning URIs in PDF files and adding them to the json report file. This change adds URI scanning support to the PDF parser, including support for object references to URIs in PDF files. Jira: CLAM-2588 Fix out-of-order references and other minor improvements. CLAM-2588, CLAM-2757
clamav_dbload_fuzzer.cpp and clamav_scanfile_fuzzer.cpp use __pid_t, which some Apple systems do not define, and this causes a compilation error. This change defines __pid_t as pid_t, which does exist on those systems and allows clamav to build.
jhumlick
force-pushed
the
CLAM-2588-PDF-Urls
branch
from
46c3aed to
f0289f0
Compare
val-ms
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to record URL's found in PDF files if the the generate JSON metadata option is enabled. This includes support for finding URIs found in object references.
Adds an option disable this in case you want the json metadata feature but don't want to record PDF URI's:
clamscancommand-line option:--json-store-pdf-uris=noclamd.confconfig option:JsonStorePDFURIs noCL_SCAN_GENERAL_STORE_PDF_URISAlso renames the options for the equivalent feature for HTML files from "URI" instead of "URL"
clamscancommand-line option:--json-store-html-uris=noclamd.confconfig option:JsonStoreHTMLURIs noCL_SCAN_GENERAL_STORE_HTML_URISJira: CLAM-2588