Merged
Conversation
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
638344d to
73a2786
Compare
Kangie
reviewed
Jun 25, 2024
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
3 times, most recently
from
685401d to
44832fc
Compare
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
4 times, most recently
from
7243032 to
5ea9ec7
Compare
val-ms
requested changes
Jul 18, 2024
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
I think I'm done with code review part. Time to do some testing.
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
2 times, most recently
from
d6705c7 to
113412e
Compare
val-ms
requested changes
Jul 18, 2024
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
f8c043a to
2c9abc4
Compare
val-ms
reviewed
Jul 19, 2024
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
eba2c5d to
44aa119
Compare
val-ms
previously approved these changes
Jul 19, 2024
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Looks great.
I also did some manual testing with a small selection of HTML files. That went well.
Approving for inclusion in 1.5.0
Store URLs found in HTML `<a>` and `<form>` tags during scan of HTML files when recording scan metadata. HTML URL recording will be ON by default, but is a part of the generate-metadata-json feature. The generate-metadata-json feature is OFF by default. This introduces a new general scan option: - libclamav: `CL_SCAN_GENERAL_STORE_HTML_URLS`. - ClamD: `JsonStoreHTMLUrls`. - ClamScan: `--json-store-html-urls` Thank you Matt Jolly for the helpful comment on the pull request.
val-ms
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
44aa119 to
666e047
Compare
Contributor
|
Rebased and removed the temporary function from the TODO. Ready to test and hopefully merge. |
val-ms
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to record URL's found in HTML if the the generate JSON metadata option is enabled.
Also adds an option disable this in case you want the json metadata feature but don't want to record HTML URL's:
clamscancommand-line option:--json-store-html-urls=noclamd.confconfig option:JsonStoreHTMLUrls noCL_SCAN_GENERAL_STORE_HTML_URLS