chore(lib/runtime/wasmer): refactor Exec and exec methods

[qdm12]

Changes

Simple refactor to adapt exec to be more independent, in order to have an instance-independent check runtime function.

• Remove nil storage check for temporary instances (some calls don't need it, and anyway we should panic if this happens imo)
• Fix for bigger than max int32 pointer and data length (before > int32 pointers/data length would crash it)
• Minor simplifications
  • Only use Exec instead of both directly wrapping exec
  • Inline single/2-lines functions content in exec: malloc, clear, store, load
  • Add sentinel errors and error wrappings
  • Add named returns

Tests

Issues

#2418

Primary Reviewer

@EclesioMeloJunior

[codecov]

Codecov Report

Merging #2686 (23151bf) into development (70181cd) will increase coverage by 0.02%.
The diff coverage is 88.00%.

@@               Coverage Diff               @@
##           development    #2686      +/-   ##
===============================================
+ Coverage        63.02%   63.04%   +0.02%     
===============================================
  Files              211      211              
  Lines            27056    27043      -13     
===============================================
- Hits             17052    17050       -2     
+ Misses            8455     8450       -5     
+ Partials          1549     1543       -6     

Flag	Coverage Δ
unit-tests	63.04% <88.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/runtime/wasmer/instance.go	56.14% <78.57%> (-1.36%)	⬇️
lib/runtime/wasmer/exports.go	57.62% <100.00%> (ø)
dot/state/block_notify.go	81.90% <0.00%> (-8.58%)	⬇️
dot/network/host.go	64.31% <0.00%> (-1.07%)	⬇️
lib/runtime/wasmer/imports.go	55.46% <0.00%> (+0.17%)	⬆️
dot/network/notifications.go	65.29% <0.00%> (+1.37%)	⬆️
dot/network/service.go	58.13% <0.00%> (+1.39%)	⬆️
dot/telemetry/mailer.go	61.19% <0.00%> (+4.47%)	⬆️
dot/network/inbound.go	100.00% <0.00%> (+7.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70181cd...23151bf. Read the comment docs.

[jimjbrettj]

Would error -> graceful shutdown be better than panicking?

[jimjbrettj]

why did we want to remove these functions?

[qdm12]

That was me trying to understand everything that was needed in that Exec method, and those tiny methods made it just hard to understand tbh.

And these 1 or 2-lines functions were only used once (in prod code, and once in a test), so I just inlined them.

So I took the EXECUTIVE DECISION to inline them pretty much 😄

[jimjbrettj]

looks good just few questions

[qdm12]

@jimjbrettj

Would error -> graceful shutdown be better than panicking?

Well in standard Go, panic should really be used only for programming errors.
But in this case, we have no way to return errors given the CGO function signature, so we agreed to panic in case of errors. Anyway these errors are very unlikely except if for example we run out of memory or our disk is physically bad for example, so it's fine to panic. Maybe one day once our service architecture is reworked, we could signal through a channel on the instance we encountered a fatal error and recover from it... but not today 😄

[github-actions]

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀