Skip to content

chore(tests): do not osExit and return error#2452

Merged
qdm12 merged 3 commits intodevelopmentfrom
qdm12/tests-refactor-3
Apr 4, 2022
Merged

chore(tests): do not osExit and return error#2452
qdm12 merged 3 commits intodevelopmentfrom
qdm12/tests-refactor-3

Conversation

@qdm12
Copy link
Copy Markdown
Contributor

@qdm12 qdm12 commented Mar 31, 2022 •
edited
Loading

Changes

  • RunGossamer: do not os.Exit and return an error
  • InitializeAndStartNodes return error and teardown nodes on error
  • InitializeAndStartNodesWebsocket return error and teardown nodes on error
  • Fix thread safety on nodes slice in InitializeAndStartNodesWebsocket.

Tests

Issues

Primary Reviewer

  • Anyone, this is trivial

@qdm12
chore(tests): do not os.Exit and return error
975290d 
- `RunGossamer`: do not os.Exit and return an error
- `InitializeAndStartNodes` return error and teardown nodes on error
- `InitializeAndStartNodesWebsocket` return error and teardown nodes on error
- Fix thread safety on nodes slice in `InitializeAndStartNodesWebsocket`
@qdm12 qdm12 marked this pull request as ready for review March 31, 2022 10:12
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #2452 (642f5ba) into development (19a2b4e) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #2452      +/-   ##
===============================================
- Coverage        58.54%   58.48%   -0.07%     
===============================================
  Files              214      214              
  Lines            28004    28004              
===============================================
- Hits             16396    16379      -17     
- Misses            9956     9970      +14     
- Partials          1652     1655       +3
Flag Coverage Δ
unit-tests 58.48% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/blocktree/node.go 65.51% <0.00%> (-6.90%) ⬇️
lib/blocktree/blocktree.go 53.62% <0.00%> (-1.09%) ⬇️
dot/network/light.go 85.25% <0.00%> (-0.80%) ⬇️
dot/network/service.go 56.84% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e700d5e...642f5ba. Read the comment docs.

EclesioMeloJunior
EclesioMeloJunior requested changes Mar 31, 2022
View reviewed changes
timwu20
timwu20 reviewed Apr 1, 2022
View reviewed changes
tests/utils/gossamer_utils.go

func InitializeAndStartNodesWebsocket(t *testing.T, num int, genesis, config string) (
nodes []*Node, err error) {
var nodesMutex, errMutex sync.Mutex
Copy link
Copy Markdown
Contributor

@timwu20 timwu20 Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use an errChan or a defined []error of len(num) to get the errors?

Copy link
Copy Markdown
Contributor Author

@qdm12 qdm12 Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, although there is little point to do this considering the future-to-be changes: this parallel logic is changed to be sequential since it takes a short time to init+start, so only the first error encountered is returned.

@qdm12 qdm12 changed the title chore(e2e): do not os.Exit and return error chore(e2e): do not os.Exit and return error Apr 1, 2022
@qdm12 qdm12 mentioned this pull request Apr 1, 2022
Merged
@qdm12 qdm12 force-pushed the qdm12/tests-refactor-3 branch from ed1d0f2 to c7dded0 Compare April 1, 2022 07:57
@qdm12 qdm12 changed the title chore(e2e): do not os.Exit and return error chore(e2e): do not os.Exit and return error Apr 1, 2022
@qdm12 qdm12 changed the title chore(e2e): do not os.Exit and return error chore(e2e): do not osExit and return error Apr 1, 2022
@qdm12 qdm12 force-pushed the qdm12/tests-refactor-3 branch from c7dded0 to 45d79d7 Compare April 1, 2022 10:55
@qdm12 qdm12 changed the title chore(e2e): do not osExit and return error chore(tests): do not osExit and return error Apr 1, 2022
@qdm12 qdm12 force-pushed the qdm12/tests-refactor-3 branch from 45d79d7 to 642f5ba Compare April 1, 2022 11:15
@qdm12 qdm12 requested a review from timwu20 April 1, 2022 15:37
@qdm12 qdm12 merged commit 2deb7dd into development Apr 4, 2022
@qdm12 qdm12 deleted the qdm12/tests-refactor-3 branch April 4, 2022 15:17
@qdm12 qdm12 mentioned this pull request Apr 11, 2022
Closed
@qdm12 qdm12 mentioned this pull request Sep 29, 2022
Merged
rrtti pushed a commit to polkadot-fellows/seeding that referenced this pull request Sep 29, 2022
@qdm12
Member Request (#28)
a37485d 
I am Quentin Mc Gaw, a software engineer working the Go Polkadot host **Gossamer**.
I have been working full time on Gossamer since October 2021, mostly on the state trie and storage.
I have also made a [few minor pull requests](https://github.com/w3f/polkadot-spec/pulls?q=is%3Apr+is%3Aclosed+author%3Aqdm12) to the Polkadot specification repository.

I am requesting to join the Fellowship at rank 1.

## Main contributions

### Gossamer

- Fix memory leaks
  - Trie encoding buffer pools usage fixed [#2009](ChainSafe/gossamer#2009)
  - Fix state map of tries memory leak [#2286](ChainSafe/gossamer#2286)
  - Fix sync benchmark [#2234](ChainSafe/gossamer#2234)
- Trie proof fixes ([#2604](ChainSafe/gossamer#2604), [#2661](ChainSafe/gossamer#2661))
- Fix end to end tests orchestration ([#2470](ChainSafe/gossamer#2470), [#2452](ChainSafe/gossamer#2452), [#2385](ChainSafe/gossamer#2385), [#2370](ChainSafe/gossamer#2370))
- State trie statistics ([#2378](ChainSafe/gossamer#2378), [#2310](ChainSafe/gossamer#2310), [#2272](ChainSafe/gossamer#2272))
- State trie fixes and improvements
  - Only deep copy nodes when mutation is certain [#2352](ChainSafe/gossamer#2352) and [#2223](ChainSafe/gossamer#2223)
  - Only deep copy necessary fields of a node [#2384](ChainSafe/gossamer#2384)
  - Use Merkle values for database keys instead of always hash [#2725](ChainSafe/gossamer#2725)
  - Opportunistic parallel Merkle value commputing [#2081](ChainSafe/gossamer#2081)
- Grandpa capped number of tracked messages ([#2490](ChainSafe/gossamer#2490), [#2485](ChainSafe/gossamer#2485))
- Add pprof HTTP service for profiling [#1991](ChainSafe/gossamer#1991)

Ongoing work:

- State trie lazy loading and caching
- State trie v1 support ([#2736](ChainSafe/gossamer#2736), [#2747](ChainSafe/gossamer#2747), [#2687](ChainSafe/gossamer#2687), [#2686](ChainSafe/gossamer#2686), [#2685](ChainSafe/gossamer#2685), [#2673](ChainSafe/gossamer#2673), [#2611](ChainSafe/gossamer#2611), [#2530](ChainSafe/gossamer#2530))

### Polkadot specification

➡️ [Pull requests from qdm12](https://github.com/w3f/polkadot-spec/pulls?q=is%3Apr+is%3Aclosed+author%3Aqdm12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timwu20 timwu20 timwu20 approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@noot noot Awaiting requested review from noot

@edwardmack edwardmack Awaiting requested review from edwardmack

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qdm12 @timwu20 @EclesioMeloJunior