Addressing deprecated traits#460
Merged
Aideepakchaudhary merged 9 commits intofeat/polkadot-stable2409from Nov 13, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addressed the deprecated traits.
Notes
Relevant upgrade's notes and comments.
Process
spec_verfor bothtestnetandmainnetRuntime.TBDCodebase Upgrade Acceptance Criteria
cargo checkpassescargo testpassescargo buildon-- releaseprofile correctly buildstry-runtimeandruntime-benchmarksfeatures compileblock-productionconfig file generates blocks.Runtime & Node Upgrade Acceptance Criteria
Runtime upgrade works on Zombienet
Node upgrade works on Zombienet
Runtime upgrade works on Chopsticks
Try-runtime passes with no pending migrations
<!--- PR TEMPLATE CONTENT STARTS HERE -->
Types of Changes
Please select the branch type you are merging and fill in the relevant template.
<!--- Check the following box with an x if the following applies: -->
Fix or Feature
<!--- Check the following box with an x if the following applies: -->
Types of Changes
<!--- What types of changes does your code introduce? -->
Migrations and Hooks
<!--- Check the following box with an x if the following applies: -->
on_initializeon_finalizeChecklist for Fix or Feature
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_versionhas been incremented.network-relayer's events have been updated according to the blockchain events if applicable.Checklist for Hotfix
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_versionhas been incremented.devhas been created.staginghas been created.network-relayer's events have been updated according to the blockchain events if applicable.Checklist for Release
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->