Feat: Polkadot v1.10 to v1.12 upgrade by Aideepakchaudhary · Pull Request #452 · Cerebellum-Network/blockchain-node

Aideepakchaudhary · 2024-10-22T12:39:24Z

Description

This PR is upgrading Runtime's and Node's dependencies from Polkadot-SDK release v1.10.0 to 1.12.0

Notes

Relevant upgrade's notes and comments.

Migration of pallet-staking and pallet-contract
Possible Breaking changes:
- [https://github.com/ improve MockValidationDataInherentDataProvider to support async backing paritytech/polkadot-sdk#4442]: Improve mock relay in --dev mode to support async backing
- [https://github.com/Export all public functions of sc-service paritytech/polkadot-sdk#4457]: sc-service: export all public functions
- [https://github.com/[balances] Safeguard against consumer ref underflow paritytech/polkadot-sdk#3865]: Balances: add failsafe for consumer ref underflow
- [https://github.com/Allow for 0 existential deposit in benchmarks for pallet_staking, pallet_session, and pallet_balances paritytech/polkadot-sdk#4346]: Allow for 0 existential deposit in benchmarks for pallet_staking, pallet_session, and pallet_balances
- [https://github.com/Assets Events for Deposited and Withdrawn paritytech/polkadot-sdk#4312]: Add Deposited/Withdrawn events for pallet-assets
Kindly refer to the official Polkadot release report for further details: Polkadot v1.12.0

Process

Bump workspace dependencies
Fix issues
Bump spec_ver for both testnet and mainnet Runtime.
Bump node version if there were changes in the node. TBD

Codebase Upgrade Acceptance Criteria

cargo check passes
cargo test passes
cargo build on -- release profile correctly builds
try-runtime and runtime-benchmarks features compile
Single node spinned up from binary works and generates blocks
Zombienet network with 2 peers spawned with block-production config file generates blocks.

Runtime & Node Upgrade Acceptance Criteria

Types of Changes

Please select the branch type you are merging and fill in the relevant template.

Hotfix
Release
Fix or Feature

Fix or Feature

Types of Changes

Tech Debt (Code improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks

This change requires a runtime migration.
Modifies on_initialize
Modifies on_finalize

Checklist for Fix or Feature

Change has been tested locally.
Change adds / updates tests if applicable.
Changelog doc updated.
spec_version has been incremented.
network-relayer's events have been updated according to the blockchain events if applicable.
All CI checks have been passed successfully

Checklist for Hotfix

Checklist for Release

…nto feat/polkadot-v1.12.0-upgrade # Conflicts: # CHANGELOG.md # Cargo.lock # Cargo.toml # runtime/cere-dev/src/lib.rs # runtime/cere/src/lib.rs

….0-upgrade

ayushmishra2005

@Aideepakchaudhary Please fix conflicts and CI

….0-upgrade

ayushmishra2005 · 2024-11-06T09:09:20Z

node/client/src/lib.rs

 	AuxStore, Backend as BackendT, BlockchainEvents, KeysIter, MerkleValue, PairsIter,
 	UsageProvider,
 };
+#[allow(deprecated)]


@Aideepakchaudhary Are we going to handle this in future PRs? If yes, please add a todo with version number

we have addressed these deprecates here in this PR: #456

ayushmishra2005 · 2024-11-06T09:09:59Z

node/client/src/lib.rs

 use sp_storage::{ChildInfo, StorageData, StorageKey};

 pub type FullBackend = sc_service::TFullBackend<Block>;
+#[allow(deprecated)]


@Aideepakchaudhary If we are handling this in future PRs, please add a todo with version number

same for this

ayushmishra2005 · 2024-11-06T09:10:16Z

node/service/src/lib.rs

 };
 pub use chain_spec::{CereChainSpec, CereDevChainSpec};
 pub use node_primitives::{Block, BlockNumber};
+#[allow(deprecated)]


@Aideepakchaudhary If we are handling this in future PRs, please add a todo with version number

same for this

ayushmishra2005

@Aideepakchaudhary paritytech/polkadot-sdk#4177 was also merged in 1.12.0. Can you include corresponding changes?

Please take a look https://github.com/paritytech/polkadot-sdk/blob/polkadot-v1.12.0/templates/solochain/runtime/build.rs for example.

Aideepakchaudhary · 2024-11-07T06:31:31Z

@Aideepakchaudhary paritytech/polkadot-sdk#4177 was also merged in 1.12.0. Can you include corresponding changes?
Please take a look https://github.com/paritytech/polkadot-sdk/blob/polkadot-v1.12.0/templates/solochain/runtime/build.rs for example.

@ayushmishra2005 , we are addressing these changes here in this PR: #456

ayushmishra2005 · 2024-11-08T10:58:02Z

@Aideepakchaudhary Please tag corresponding polkadot upgrade PR. For example #456 instead of #460

metricaez and others added 16 commits October 8, 2024 12:46

feat: bump dependencies and fix runtime issues

0a1e132

fix: update node

ff7991d

choir: warnings and allow deprecate for later address

62a3a74

update mock

b0577a6

bump spec_version and node version

55f8294

update changelog

96624cc

fmt

0727774

fmt toml

d384cde

fix

6ce8396

Merge remote-tracking branch 'origin/feat/polkadot-v1.10.0-upgrade' i…

6f78aa6

…nto feat/polkadot-v1.12.0-upgrade # Conflicts: # CHANGELOG.md # Cargo.lock # Cargo.toml # runtime/cere-dev/src/lib.rs # runtime/cere/src/lib.rs

pallet contract migration

a880418

fix CI and code cleanup

805e9f3

update derive macro

72a266b

fmt

0f90843

Merge branch 'feat/polkadot-v1.10.0-upgrade' into feat/polkadot-v1.12…

865ce2a

….0-upgrade

replace struct with enum

5cd04dc

ayushmishra2005 suggested changes Nov 5, 2024

View reviewed changes

Aideepakchaudhary and others added 3 commits November 5, 2024 16:03

fix conflict

03d8d42

Merge branch 'feat/polkadot-v1.10.0-upgrade' into feat/polkadot-v1.12…

74222ae

….0-upgrade

fix conflict

2c20f07

ayushmishra2005 suggested changes Nov 6, 2024

View reviewed changes

ayushmishra2005 approved these changes Nov 14, 2024

View reviewed changes

Aideepakchaudhary self-assigned this Jan 2, 2025

ayushmishra2005 closed this Jan 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Polkadot v1.10 to v1.12 upgrade#452

Feat: Polkadot v1.10 to v1.12 upgrade#452
Aideepakchaudhary wants to merge 19 commits intofeat/polkadot-v1.10.0-upgradefrom
feat/polkadot-v1.12.0-upgrade

Aideepakchaudhary commented Oct 22, 2024 •

edited

Loading

Uh oh!

ayushmishra2005 left a comment

Uh oh!

ayushmishra2005 Nov 6, 2024

Uh oh!

Aideepakchaudhary Nov 7, 2024 •

edited

Loading

Uh oh!

ayushmishra2005 Nov 6, 2024

Uh oh!

Aideepakchaudhary Nov 7, 2024

Uh oh!

ayushmishra2005 Nov 6, 2024

Uh oh!

Aideepakchaudhary Nov 7, 2024

Uh oh!

ayushmishra2005 left a comment

Uh oh!

Aideepakchaudhary commented Nov 7, 2024 •

edited

Loading

Uh oh!

ayushmishra2005 commented Nov 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Aideepakchaudhary commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes

Process

Codebase Upgrade Acceptance Criteria

Runtime & Node Upgrade Acceptance Criteria

Types of Changes

Fix or Feature

Types of Changes

Migrations and Hooks

Checklist for Fix or Feature

Checklist for Hotfix

Checklist for Release

Uh oh!

ayushmishra2005 left a comment

Choose a reason for hiding this comment

Uh oh!

ayushmishra2005 Nov 6, 2024

Choose a reason for hiding this comment

Uh oh!

Aideepakchaudhary Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ayushmishra2005 Nov 6, 2024

Choose a reason for hiding this comment

Uh oh!

Aideepakchaudhary Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

ayushmishra2005 Nov 6, 2024

Choose a reason for hiding this comment

Uh oh!

Aideepakchaudhary Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

ayushmishra2005 left a comment

Choose a reason for hiding this comment

Uh oh!

Aideepakchaudhary commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ayushmishra2005 commented Nov 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Aideepakchaudhary commented Oct 22, 2024 •

edited

Loading

Aideepakchaudhary Nov 7, 2024 •

edited

Loading

Aideepakchaudhary commented Nov 7, 2024 •

edited

Loading