Skip to content

Level Zero - Fix OOM & Improve Thread Safety #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvelesko merged 15 commits into from
May 8, 2024
Merged

Level Zero - Fix OOM & Improve Thread Safety #845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
58be990
LZEventPool::LZEventPool use make_shared for event
pvelesko May 2, 2024
064ee70
Re-enable event tracking
pvelesko May 3, 2024
d22060e
remove GlobalLastEventMtx
pvelesko May 3, 2024
a1eb785
updateFinishStatus mtx move outside
pvelesko Apr 30, 2024
108b27d
remove mtx CHIPEventLevel0::reset
pvelesko May 2, 2024
7355a93
Implement ApiMtx
pvelesko May 3, 2024
1a6af44
refactor CHIPEventLevel0::wait()
pvelesko Apr 30, 2024
9ef724b
LZEventPool::returnEvent by ref
pvelesko May 3, 2024
820890d
updateFinishStatus remove str
pvelesko May 3, 2024
4ecb3db
Fix event return w/custom destr
pvelesko May 4, 2024
a274e11
EventPool - cleanup
pvelesko May 4, 2024
582929a
cleanup
pvelesko May 5, 2024
9f3d2da
fixup oneapi libdirs
pvelesko May 8, 2024
421f636
update HIP submodule
pvelesko May 8, 2024
ab3b950
fix L0::recordEvent dependencies, event pool dest, add mtx
pvelesko May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HIP
Open in desktop
Submodule HIP updated 3 files
+9 −0 tests/catch/external/Catch2/catch.hpp
+1 −0 tests/catch/external/Catch2/cmake/Catch2/Catch.cmake
+2 −1 tests/catch/external/Catch2/cmake/Catch2/CatchAddTests.cmake
6 changes: 2 additions & 4 deletions cmake/mkl_and_icpx.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ find_program(ICPX_EXECUTABLE NAMES icpx

if(ICPX_EXECUTABLE)
get_filename_component(ICPX_CORE_BINDIR ${ICPX_EXECUTABLE} DIRECTORY)
get_filename_component(ICPX_CORE_LIBDIR "${ICPX_CORE_BINDIR}/../../linux/compiler/lib/intel64_lin" ABSOLUTE)
get_filename_component(ICPX_SYCL_LIBDIR "${ICPX_CORE_BINDIR}/../../linux/lib" ABSOLUTE)
get_filename_component(ICPX_CORE_LIBDIR "${ICPX_CORE_BINDIR}/../lib" ABSOLUTE)
endif()

# the ENABLE_OMP_OFFLOAD is only required to unhide MKL::sycl in intel's MKLConfig.cmake file
Expand All @@ -22,8 +21,7 @@ if(MKL_FOUND)
add_link_options(-L${MKL_ROOT}/lib/${MKL_ARCH})
endif()

# message(STATUS "ICPX : ${ICPX_EXECUTABLE} MKL: ${MKL_FOUND} ")
set(INTEL_LIBS -L${ICPX_SYCL_LIBDIR} -L${ICPX_CORE_LIBDIR} -lsvml -lintlc -lirng -limf -lsycl)
set(INTEL_LIBS -L${ICPX_CORE_LIBDIR} -lsvml -lintlc -lirng -limf -lsycl)

if(ICPX_EXECUTABLE AND MKL_FOUND)
message(STATUS "Found both MLK and ICPX")
Expand Down
2 changes: 0 additions & 2 deletions src/CHIPBackend.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1503,8 +1503,6 @@ chipstar::Queue::getSyncQueuesLastEvents(std::shared_ptr<chipstar::Event> Event,
if (!NumUserQueues && !IncludeSelfLastEvent)
return {EventsToWaitOn, std::move(EventLocks)};

EventLocks.push_back(std::make_unique<std::unique_lock<std::mutex>>(
::Backend->GlobalLastEventMtx));
EventLocks.push_back(
std::make_unique<std::unique_lock<std::mutex>>(::Backend->EventsMtx));

Expand Down
1 change: 0 additions & 1 deletion src/CHIPBackend.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1870,7 +1870,6 @@ public:

std::mutex SetActiveMtx;
std::mutex QueueCreateDestroyMtx;
mutable std::mutex GlobalLastEventMtx;
mutable std::mutex BackendMtx;
mutable std::mutex ActiveCtxMtx;
std::mutex CallbackQueueMtx;
Expand Down
Loading