Level Zero - Fix OOM & Improve Thread Safety #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvelesko
force-pushed
the
thread-safety
branch
2 times, most recently
from
67ec73e to
54e85b3
Compare
pvelesko
changed the title
linehill
reviewed
May 7, 2024
linehill
reviewed
May 7, 2024
Prevent valgrind from complaining about races Data races reported from inside the driver Even though it's supposed to be thread safe
define DBL_MAX_10_EXP which is undefined if float.h is picked up from intel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHIPEventLevel0::wait()to get rid of race conditions reported by valgrind. The API states that calls tozeEventHostSynchronizeandzeEventQueryare thread safe but valgrind reports race conditions.ApiMtxwhich is to be locked by every HIP API call. This prevents multiple HIP commands from executing at the same time. Pretty coarse lock which we can relax over time since performance is affected only for multithreaded HIP applications of which I haven't seen any yet.