Skip to content

Test PR #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
midhunadarvin wants to merge 1 commit into from
+49 −175
Closed

Test PR #4257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/utils/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@builder.io/utils",
"version": "1.1.29",
"version": "1.1.27",
"description": "Utils for working with Builder.io content",
"main": "./dist/index.js",
"scripts": {
Expand Down
58 changes: 25 additions & 33 deletions packages/utils/src/__snapshots__/translation-helpers.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,31 +322,6 @@ Object {
}
`;

exports[`getTranslateableFields from carousel content and custom component with subFields to match snapshot 1`] = `
Object {
"blocks.builder-06d3f6da74fb4054ad311afc1dda3675#text": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>I am slide second</p>",
},
"blocks.builder-0a10ae48b6314221bbb7d06d068d623d#text": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>I am slide 1</p>",
},
"blocks.builder-23e0618256ab40799ecf6504bc57fa1c#listItems.0.field1": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>text 1 value</p>",
},
"blocks.builder-23e0618256ab40799ecf6504bc57fa1c#listItems.1.field1": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>text 1.1 value</p>",
},
"blocks.builder-23e0618256ab40799ecf6504bc57fa1c#title.text": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>custom component subField input</p>",
},
}
`;

Copy link

@cursor cursor bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test snapshot mismatch for button translation extraction

Medium Severity

The snapshot removes expected entries for blocks.button-localized-text-id#text and blocks.button-plain-text-id#text, but the actual code in translation-helpers.ts still contains Core:Button handling logic that extracts button text. The test data includes button components that will be extracted by the code, causing the snapshot test to fail.

Fix in Cursor Fix in Web

exports[`getTranslateableFields from content to match snapshot 1`] = `
Object {
"blocks.block-id#text": Object {
Expand Down Expand Up @@ -385,14 +360,6 @@ Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "en-us headings!",
},
"blocks.button-localized-text-id#text": Object {
"instructions": "Button with pre-localized text",
"value": "Click Me!",
},
"blocks.button-plain-text-id#text": Object {
"instructions": "Button with plain text",
"value": "Cute Baby",
},
"metadata.seo": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": Object {
Expand All @@ -419,3 +386,28 @@ Object {
},
}
`;

exports[`getTranslateableFields from carousel content and custom component with subFields to match snapshot 1`] = `
Object {
"blocks.builder-06d3f6da74fb4054ad311afc1dda3675#text": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>I am slide second</p>",
},
"blocks.builder-0a10ae48b6314221bbb7d06d068d623d#text": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>I am slide 1</p>",
},
"blocks.builder-23e0618256ab40799ecf6504bc57fa1c#listItems.0.field1": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>text 1 value</p>",
},
"blocks.builder-23e0618256ab40799ecf6504bc57fa1c#listItems.1.field1": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>text 1.1 value</p>",
},
"blocks.builder-23e0618256ab40799ecf6504bc57fa1c#title.text": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>custom component subField input</p>",
},
}
`;
54 changes: 8 additions & 46 deletions packages/utils/src/translation-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,27 +220,8 @@ export function getTranslateableFields(

// blocks
if (blocks) {
// Track how many levels deep we are inside excluded blocks
let excludedDepth = 0;

traverse(blocks).forEach(function (el) {
// Check if this element starts an exclusion zone
const startsExclusion = el && el.meta?.excludeFromTranslation;
if (startsExclusion) {
excludedDepth++;
}

// After processing children, decrement the counter if this element started an exclusion
this.after(function () {
if (startsExclusion) {
excludedDepth--;
}
});

// Skip translation if we're inside an excluded block (excludedDepth > 0)
const isExcluded = excludedDepth > 0;

if (this.key && el && el.meta?.localizedTextInputs && !isExcluded) {
if (this.key && el && el.meta?.localizedTextInputs) {
const localizedTextInputs = el.meta.localizedTextInputs as string[];
if (localizedTextInputs && Array.isArray(localizedTextInputs)) {
localizedTextInputs
Expand All @@ -257,7 +238,7 @@ export function getTranslateableFields(
});
}
}
if (el && el.id && el.component?.name === 'Text' && !isExcluded) {
if (el && el.id && el.component?.name === 'Text' && !el.meta?.excludeFromTranslation) {
const componentText = el.component.options.text;
results[`blocks.${el.id}#text`] = {
value:
Expand All @@ -268,7 +249,7 @@ export function getTranslateableFields(
};
}

if (el && el.id && el.component?.name === 'Core:Button' && !isExcluded) {
if (el && el.id && el.component?.name === 'Core:Button' && !el.meta?.excludeFromTranslation) {
const componentText = el.component.options?.text;
if (componentText) {
const textValue = typeof componentText === 'string'
Expand All @@ -283,7 +264,7 @@ export function getTranslateableFields(
}
}

if (el && el.id && el.component?.name === 'Symbol'&& !isExcluded) {
Copy link

@cursor cursor bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested blocks ignore parent's translation exclusion setting

High Severity

The hierarchical excludedDepth tracking for translation exclusion was removed. Previously, when a parent block was marked with excludeFromTranslation, all its children would automatically be excluded. Now children only check their own meta.excludeFromTranslation property, ignoring the parent's exclusion setting. This causes nested elements to be incorrectly sent for translation even when their container is explicitly excluded.

Additional Locations (1)

Fix in Cursor Fix in Web

if (el && el.id && el.component?.name === 'Symbol') {
Copy link

@cursor cursor bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbol and custom components ignore exclusion entirely

Medium Severity

The excludeFromTranslation check was completely removed from Symbol components and custom components with localizedTextInputs. These component types will now always be included in translation regardless of any exclusion setting, unlike Text and Core:Button components which still check for exclusion.

Additional Locations (1)

Fix in Cursor Fix in Web

const symbolInputs = Object.entries(el.component?.options?.symbol?.data) || [];
if (symbolInputs.length) {
const basePath = `blocks.${el.id}.symbolInput`;
Expand Down Expand Up @@ -335,27 +316,8 @@ export function applyTranslation(
}

if (blocks) {
// Track how many levels deep we are inside excluded blocks
let excludedDepth = 0;

traverse(blocks).forEach(function (el) {
// Check if this element starts an exclusion zone
const startsExclusion = el && el.meta?.excludeFromTranslation;
if (startsExclusion) {
excludedDepth++;
}

// After processing children, decrement the counter if this element started an exclusion
this.after(function () {
if (startsExclusion) {
excludedDepth--;
}
});

// Skip translation if we're inside an excluded block (excludedDepth > 0)
const isExcluded = excludedDepth > 0;

if (el && el.id && el.component?.name === 'Symbol' && !isExcluded) {
if (el && el.id && el.component?.name === 'Symbol') {
const symbolInputs = Object.entries(el.component?.options?.symbol?.data) || [];
if (symbolInputs.length) {
const transformedMeta = {};
Expand Down Expand Up @@ -406,7 +368,7 @@ export function applyTranslation(
el &&
el.id &&
el.component?.name === 'Text' &&
!isExcluded &&
!el.meta?.excludeFromTranslation &&
translation[`blocks.${el.id}#text`]
) {
const localizedValues =
Expand Down Expand Up @@ -443,7 +405,7 @@ export function applyTranslation(
el &&
el.id &&
el.component?.name === 'Core:Button' &&
!isExcluded &&
!el.meta?.excludeFromTranslation &&
translation[`blocks.${el.id}#text`]
) {
const localizedValues =
Expand Down Expand Up @@ -478,7 +440,7 @@ export function applyTranslation(
}

// custom components
if (el && el.id && el.meta?.localizedTextInputs && !isExcluded) {
if (el && el.id && el.meta?.localizedTextInputs) {
// there's a localized input
const keys = el.meta?.localizedTextInputs as string[];
let options = el.component.options;
Expand Down
18 changes: 9 additions & 9 deletions plugins/smartling/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions plugins/smartling/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@builder.io/plugin-smartling",
"version": "0.0.23-13",
"version": "0.0.23-11",
"description": "",
"keywords": [],
"main": "dist/plugin.system.js",
Expand Down Expand Up @@ -125,7 +125,7 @@
"typescript": "^3.0.3"
},
"dependencies": {
"@builder.io/utils": "1.1.29",
"@builder.io/utils": "1.1.26",
Copy link

@cursor cursor bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency version mismatch between package.json and lockfile

Medium Severity

The @builder.io/utils dependency version in package.json is 1.1.26 but the package-lock.json locks to 1.1.25-2. These versions don't match, and neither corresponds to the actual utils package version (1.1.27). This inconsistency can cause unpredictable build behavior depending on whether npm uses the lockfile or resolves fresh.

Additional Locations (1)

Fix in Cursor Fix in Web

"fast-json-stable-stringify": "^2.1.0",
"lodash": "^4.17.21",
"object-hash": "^3.0.0",
Expand Down
84 changes: 2 additions & 82 deletions plugins/smartling/src/plugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,6 @@ Builder.register('plugin', {
advanced: false,
requiredPermissions: ['admin'],
},
{
name: 'enableVisualContextCapture',
friendlyName: 'Enable Visual Context Capture',
type: 'boolean',
defaultValue: false,
helperText: 'Enable automatic visual context capture for translations',
requiredPermissions: ['admin'],
},
],
onSave: async actions => {
const pluginPrivateKey = await appState.globalState.getPluginPrivateKey(pkg.name);
Expand Down Expand Up @@ -468,7 +460,7 @@ const initializeSmartlingPlugin = async () => {
}
const element = selectedElements[0];
const isExcluded = element.meta?.get(transcludedMetaKey);
return !isExcluded;
return element.component?.name === 'Text' && !isExcluded;
},
onClick(elements) {
elements.forEach(el => el.meta.set('excludeFromTranslation', true));
Expand All @@ -484,85 +476,13 @@ const initializeSmartlingPlugin = async () => {
}
const element = selectedElements[0];
const isExcluded = element.meta?.get(transcludedMetaKey);
return isExcluded;
return element.component?.name === 'Text' && isExcluded;
},
onClick(elements) {
elements.forEach(el => el.meta.set('excludeFromTranslation', false));
},
});


registerContextMenuAction({
label: 'Add String Instructions',
showIf(selectedElements) {
if (selectedElements.length !== 1) {
// todo maybe apply for multiple
return false;
}
const element = selectedElements[0];
return element.meta?.get('instructions') === undefined;
},
async onClick(elements) {
if (elements.length !== 1) {
// todo maybe apply for multiple
return false;
}
const instructions = await appState.dialogs.prompt({
placeholderText: 'Enter string instructions for translation',
});
if (instructions) {
elements[0].meta.set('instructions', instructions);
appState.snackBar.show('String instructions added to content');
}
},
});

registerContextMenuAction({
label: 'Edit String Instructions',
showIf(selectedElements) {
if (selectedElements.length !== 1) {
// todo maybe apply for multiple
return false;
}
const element = selectedElements[0];
return element.meta?.get('instructions') !== undefined;
},
async onClick(elements) {
if (elements.length !== 1) {
// todo maybe apply for multiple
return false;
}
const element = elements[0];
const instructions = element.meta?.get('instructions');
if (instructions !== undefined) {
const newInstructions = await appState.dialogs.prompt({
placeholderText: 'Enter new string instructions for translation',
defaultValue: instructions,
});
if (newInstructions) {
element.meta.set('instructions', newInstructions);
appState.snackBar.show('String instructions updated');
}
}
},
});

registerContextMenuAction({
label: 'Delete String Instructions',
showIf(selectedElements) {
if (selectedElements.length !== 1) {
// todo maybe apply for multiple
return false;
}
const element = selectedElements[0];
return element.meta?.get('instructions') !== undefined;
},
onClick(elements) {
elements[0].meta.delete('instructions');
appState.snackBar.show('String instructions deleted');
},
});

registerContentAction({
label: 'Add to translation job',
showIf(content, model) {
Expand Down
Loading