Test PR #4257
Test PR #4257
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 0d1bbff
☁️ Nx Cloud last updated this comment at |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| } | ||
| } | ||
|
|
||
| if (el && el.id && el.component?.name === 'Symbol'&& !isExcluded) { |
There was a problem hiding this comment.
Nested blocks ignore parent's translation exclusion setting
High Severity
The hierarchical excludedDepth tracking for translation exclusion was removed. Previously, when a parent block was marked with excludeFromTranslation, all its children would automatically be excluded. Now children only check their own meta.excludeFromTranslation property, ignoring the parent's exclusion setting. This causes nested elements to be incorrectly sent for translation even when their container is explicitly excluded.
Additional Locations (1)
| } | ||
|
|
||
| if (el && el.id && el.component?.name === 'Symbol'&& !isExcluded) { | ||
| if (el && el.id && el.component?.name === 'Symbol') { |
There was a problem hiding this comment.
Symbol and custom components ignore exclusion entirely
Medium Severity
The excludeFromTranslation check was completely removed from Symbol components and custom components with localizedTextInputs. These component types will now always be included in translation regardless of any exclusion setting, unlike Text and Core:Button components which still check for exclusion.
Additional Locations (1)
| }, | ||
| } | ||
| `; | ||
|
|
There was a problem hiding this comment.
Test snapshot mismatch for button translation extraction
Medium Severity
The snapshot removes expected entries for blocks.button-localized-text-id#text and blocks.button-plain-text-id#text, but the actual code in translation-helpers.ts still contains Core:Button handling logic that extracts button text. The test data includes button components that will be extracted by the code, causing the snapshot test to fail.
| }, | ||
| "dependencies": { | ||
| "@builder.io/utils": "1.1.29", | ||
| "@builder.io/utils": "1.1.26", |
There was a problem hiding this comment.
Dependency version mismatch between package.json and lockfile
Medium Severity
The @builder.io/utils dependency version in package.json is 1.1.26 but the package-lock.json locks to 1.1.25-2. These versions don't match, and neither corresponds to the actual utils package version (1.1.27). This inconsistency can cause unpredictable build behavior depending on whether npm uses the lockfile or resolves fresh.
…ude blocks, edit/add/delete string instructions (#4218)"
This reverts commit 8bcaa92.
Description
Add a short description of what changes you made, why you made them, and any other context that you think might be helpful for someone to better understand what is contained in this pull request. This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.
Screenshot
If relevant, add a screenshot or two of the changes you made.
Note
Medium Risk
Changes affect translation string extraction/application and remove Smartling editor actions, which can alter what content gets sent for translation and what controls users have in the UI; behavior changes should be verified on real content with nested excluded blocks and symbols.
Overview
Reverts prior Smartling/translation changes by downgrading package versions (
@builder.io/utilsto1.1.27, Smartling plugin to0.0.23-11, and Smartling’s@builder.io/utilsdependency), updating lockfiles accordingly.In
translation-helpers, removes the “excluded block depth” traversal logic; exclusion now only checksel.meta.excludeFromTranslationon theText/Core:Buttonelement itself (and no longer gatesSymbolorlocalizedTextInputsprocessing), with Jest snapshots updated to match the new extraction behavior.In the Smartling plugin, removes the
enableVisualContextCapturesetting, limits “Exclude/Include from future translations” context menu actions toTextcomponents, and removes the context menu actions for adding/editing/deleting per-string translation instructions.Written by Cursor Bugbot for commit 0d1bbff. This will update automatically on new commits. Configure here.