Skip to content

Comments

GR mods#67

Open
russkel wants to merge 19 commits intoBrettRD:ros2from
Greenroom-Robotics:feature/tracing
Open

GR mods#67
russkel wants to merge 19 commits intoBrettRD:ros2from
Greenroom-Robotics:feature/tracing

Conversation

@russkel
Copy link
Contributor

@russkel russkel commented Jun 19, 2024

Hi Brett,

As per our chat yesterday, here's the mods I made to the bridge.

Let me know what parts you're interested in merging and I can clean up the PR.

Russ

@BrettRD
Copy link
Owner

BrettRD commented Feb 7, 2025

Thanks for sharing these!
I've cherry-picked 6dc2832 and a0e5c87 into the develop branch

The trace tools look like they would be useful for diagnosing some recent reported issues, but I'd like the option to exclude it from a minimal build

I would still like to pursue #63

Cheers

@russkel
Copy link
Contributor Author

russkel commented Feb 12, 2025

The trace tools look like they would be useful for diagnosing some recent reported issues, but I'd like the option to exclude it from a minimal build

Yep this would be good. I will see how the other ros2 project do it and replicate that CMake arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants