feat: add manual time offset to rosimagesink image publisher#63
Open
keniee wants to merge 3 commits intoBrettRD:ros2from
Open
feat: add manual time offset to rosimagesink image publisher#63keniee wants to merge 3 commits intoBrettRD:ros2from
keniee wants to merge 3 commits intoBrettRD:ros2from
Conversation
Owner
|
Thanks for the PR! The new prop looks good, I'm happy to include it with a few tweaks:
If you were to apply the timestamp in the render method of rosbasesink, it will correctly inherit to all of the other ros*sink types. Thanks again! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature enables an offset time specified in nanoseconds to modify the timestamp of the published ros image topic. A parameter ros-time-offset is added as a specifier to rosimagesink.
Usage Example adds 10s to the current timestamp of a published image:
gst-launch-1.0 videotestsrc pattern=ball ! video/x-raw, format=RGB,width=1280,height=720 ! timeoverlay ! queue ! rosimagesink ros-topic=test/image ros-name='gst_rosimagesink_camera' ros-namespace='gst' ros-frame-id='camera_frame' ros-time-offset=10000000000 throttle-time=0