Skip to content

Conversation

@mikaoelitiana
Copy link
Contributor

fixes #1055

work-in-progress

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 22, 2018
@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 14, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Sep 14, 2018

@mikaoelitiana Did you finish the work?

@mikaoelitiana
Copy link
Contributor Author

@Rokt33r yes I made all requested changes from previsou PR

@Rokt33r Rokt33r added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Sep 15, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Sep 15, 2018

screen shot 2018-09-15 at 11 47 19

It doesn't work on Windows. Is it possible for you to enable it on only macOS? I didn't try yet but I assume it doesn't work on linux too.

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 15, 2018
@mikaoelitiana
Copy link
Contributor Author

@Rokt33r I will check that (sorry didn't have Windows to test)

@yougotwill
Copy link
Member

Any updates on this @mikaoelitiana? :)

@mikaoelitiana
Copy link
Contributor Author

@yougotwill I added a condition to make it used on osx only.

@Rokt33r
Copy link
Member

Rokt33r commented Oct 12, 2018

@mikaoelitiana Could you fix the conflicts?

@mikaoelitiana
Copy link
Contributor Author

mikaoelitiana commented Oct 12, 2018 via email

@Flexo013
Copy link
Contributor

Flexo013 commented Dec 6, 2019

Obsolete due to #2509

@Flexo013 Flexo013 closed this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: macOS - Title Bar & Dark Color Theme

6 participants