Add support to powerline themes to override foreground color#2231
Merged
davidpfarrell merged 1 commit intoBash-it:masterfrom Nov 18, 2023
Merged
Add support to powerline themes to override foreground color#2231davidpfarrell merged 1 commit intoBash-it:masterfrom
davidpfarrell merged 1 commit intoBash-it:masterfrom
Conversation
Contributor
Author
|
CI failures are not due to the change. |
davidpfarrell
approved these changes
Nov 18, 2023
Contributor
davidpfarrell
left a comment
davidpfarrell
left a comment
There was a problem hiding this comment.
Re-running the jobs eventually passed.
This seems quite useful and doesn't seem like it would break anything, so lets do iit!
jakebman
added a commit
to jakebman/bash-it
that referenced
this pull request
Jan 15, 2024
Add support to powerline themes to override foreground color (Bash-it#2231)
douglasjacobsen
added a commit
to douglasjacobsen/bash-it
that referenced
this pull request
Jan 19, 2024
* upstream/master: (1190 commits) Add support to powerline themes to override foreground color (Bash-it#2231) ci: Update GitHub actions v2 => v4 (Bash-it#2224) docs: Update Bats libraries links (Bash-it#2225) fix: bumps go version to 1.21.0 and changes go get to go install [terraform] add alias for terraform workspace fix (completion): suppress 1091 in brew (Bash-it#2130) Allow for longer command min duration (Bash-it#2198) Implement yarn completion (Bash-it#2190) Fix lint errors in multiple files (Bash-it#2192) bug: Use C style strings when checking for invalid alias characters (Bash-it#2188) Remove libra chat reference Add more aliases for `git branch`, use long form remove function wrapper around kubectl alias registration bug: Use en_US when fetching EPOCHREALTIME bug:Install shellcheck wget (Bash-it#2173) fix(theme): use correct escape sequence to avoid weird text overwriting chore: Use grep -E / grep -F instead of egrep / fgrep (Bash-it#2164) Fixed broken code blocks in troubleshooting.rst Removed Bash Dependency section from README and added it to troubleshooting.rst Update variable name to match projects.plugin.bash ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change allows the override of foreground color for the powerline themes. You can change the foreground color by settings
POWERLINE_PROMPT_FOREGROUND_COLOR. It still retains the default of using the terminal foreground color.Motivation and Context
For people that use themes like solarized dark, the contrast between the standard terminal text and certain backgrounds makes it very hard to read. This allows for changing the foreground text to something like '15' (bright white) making the prompt much more legible.
How Has This Been Tested?
This has only been tested locally. You can see in the screenshot the default behavior and after changing the foreground color to '15' in my .bashrc.
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.