ci: Update GitHub actions#2224
Merged
davidpfarrell merged 1 commit intoBash-it:masterfrom Oct 3, 2023
Merged
Conversation
hyperupcall
force-pushed
the
hyperupcall-update-actions
branch
3 times, most recently
from
7f9ca91 to
3172144
Compare
davidpfarrell
suggested changes
Oct 3, 2023
Contributor
davidpfarrell
left a comment
davidpfarrell
left a comment
There was a problem hiding this comment.
Hey thanks for taking the the time for this !!!
I know you'll want to revert your go/shfmt changes and rebase against the new main, but also:
Without the quotes, it feels like this simply becomes s/@v2/@v4/ which I'd feel more comfortable with.
Unless they're needed? i.e does v4 require them where v2 didn't ?
hyperupcall
force-pushed
the
hyperupcall-update-actions
branch
from
3172144 to
ff22082
Compare
Contributor
Author
|
@davidpfarrell I touched on it a bit here, but you're right that these particular strings do not need to be quoted. Usually, it is good to quote I rebased my changes over |
davidpfarrell
approved these changes
Oct 3, 2023
Contributor
davidpfarrell
left a comment
davidpfarrell
left a comment
There was a problem hiding this comment.
Looks clean - Thanks !
douglasjacobsen
added a commit
to douglasjacobsen/bash-it
that referenced
this pull request
Jan 19, 2024
* upstream/master: (1190 commits) Add support to powerline themes to override foreground color (Bash-it#2231) ci: Update GitHub actions v2 => v4 (Bash-it#2224) docs: Update Bats libraries links (Bash-it#2225) fix: bumps go version to 1.21.0 and changes go get to go install [terraform] add alias for terraform workspace fix (completion): suppress 1091 in brew (Bash-it#2130) Allow for longer command min duration (Bash-it#2198) Implement yarn completion (Bash-it#2190) Fix lint errors in multiple files (Bash-it#2192) bug: Use C style strings when checking for invalid alias characters (Bash-it#2188) Remove libra chat reference Add more aliases for `git branch`, use long form remove function wrapper around kubectl alias registration bug: Use en_US when fetching EPOCHREALTIME bug:Install shellcheck wget (Bash-it#2173) fix(theme): use correct escape sequence to avoid weird text overwriting chore: Use grep -E / grep -F instead of egrep / fgrep (Bash-it#2164) Fixed broken code blocks in troubleshooting.rst Removed Bash Dependency section from README and added it to troubleshooting.rst Update variable name to match projects.plugin.bash ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI hasn't been updated in a hot while. This updates the actions to their latest and greates versions. It also fixes issues with the Go version being too low for
shfmt.Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.