Skip to content

Use grep -E instead of egrep#2168

Closed
tbhaxor wants to merge 4 commits intoBash-it:masterfrom
tbhaxor:fix/grep
Closed

Use grep -E instead of egrep#2168
tbhaxor wants to merge 4 commits intoBash-it:masterfrom
tbhaxor:fix/grep

Conversation

@tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Oct 7, 2022

Description

egrep binary is obselete and should be replaced with grep -E

Screenshot_20221007_195336

Motivation and Context

This change will remove the annoying warning message from the console

How Has This Been Tested?

Screenshots (if appropriate):

After fixing it would not echo the warning

Screenshot_20221007_195548

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@davidpfarrell
Copy link
Contributor

Hey @tbhaxor !!

Looks like you may have missed the existing discussion on the issue:

And my (nearly approved for merge) Pull Request:

Also, another PR that came in after mine:

A quick glance suggests my PR contains these changes, and a few more, but it would be great if you could take a once-over of mine and confirm.

Thanks!
-D

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Oct 7, 2022

Hello @davidpfarrell, a lot of PRs are pending to merge. It is missed

Closing in favor of previous pull requests already opened.

@tbhaxor tbhaxor closed this Oct 7, 2022
@tbhaxor tbhaxor deleted the fix/grep branch October 7, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants