Skip to content

Replace egrep with grep -E#2167

Closed
dracorp wants to merge 3 commits intoBash-it:masterfrom
dracorp:feature/grep
Closed

Replace egrep with grep -E#2167
dracorp wants to merge 3 commits intoBash-it:masterfrom
dracorp:feature/grep

Conversation

@dracorp
Copy link
Contributor

@dracorp dracorp commented Oct 2, 2022

Description

This change replace egrep with grep -E.

Motivation and Context

To prevent a warning:

egrep: warning: egrep is obsolescent; using grep -E

How Has This Been Tested?

None

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@davidpfarrell
Copy link
Contributor

Hi ! Thanks for taking the time and effort to make bash-it better !

Wondering if you've seen my similar PR:

And this discussion on the egrep fiasco:

I'll try to take a pass and see if you caught anything I missed in my PR.

Thanks again !

-Dave

@davidpfarrell
Copy link
Contributor

OK I compared the two PRs and I think my PR captures all of these changes, and a few others ...

@dracorp
Copy link
Contributor Author

dracorp commented Oct 3, 2022

@davidpfarrell
Yes, I agree. Thanks.

@dracorp dracorp closed this Oct 3, 2022
@davidpfarrell davidpfarrell mentioned this pull request Oct 7, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants