Replace egrep with grep -E#2167
Closed
dracorp wants to merge 3 commits intoBash-it:masterfrom
dracorp:feature/grep
Closed
Replace egrep with grep -E#2167dracorp wants to merge 3 commits intoBash-it:masterfrom dracorp:feature/grep
dracorp wants to merge 3 commits intoBash-it:masterfrom
dracorp:feature/grep
Conversation
Contributor
|
Hi ! Thanks for taking the time and effort to make bash-it better ! Wondering if you've seen my similar PR: And this discussion on the egrep fiasco: I'll try to take a pass and see if you caught anything I missed in my PR. Thanks again ! -Dave |
Contributor
|
OK I compared the two PRs and I think my PR captures all of these changes, and a few others ... |
Contributor
Author
|
@davidpfarrell |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change replace egrep with grep -E.
Motivation and Context
To prevent a warning:
egrep: warning: egrep is obsolescent; using grep -EHow Has This Been Tested?
None
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.