lib/helpers: new function to set BASH_IT_HOMEBREW_PREFIX#1910
Merged
NoahGorny merged 3 commits intoBash-it:masterfrom Aug 26, 2021
Merged
lib/helpers: new function to set BASH_IT_HOMEBREW_PREFIX#1910NoahGorny merged 3 commits intoBash-it:masterfrom
NoahGorny merged 3 commits intoBash-it:masterfrom
Conversation
gaelicWizard
force-pushed
the
brew
branch
2 times, most recently
from
c341e19 to
573889e
Compare
NoahGorny
approved these changes
Aug 11, 2021
Member
NoahGorny
left a comment
NoahGorny
left a comment
There was a problem hiding this comment.
Very nice and clean PR!
I will let others chime in if they want 😄
NoahGorny
reviewed
Aug 14, 2021
6 tasks
Member
|
we should maybe add some tests here to verify the logic wont be broken in the future. testing |
New function `_bash_it_homebrew_check()` sets global variable `$BASH_IT_HOMEBREW_PREFIX` using `brew --prefix` if `brew` exists as a valid command. If `brew` isn't installed, then return failure. Plugins can test for `brew` by calling this function and, if it succeeds, they can rely on `$BASH_IT_HOMEBREW_PREFIX` being defined properly.
Use new function `_bash_it_homebrew_check()` in existing plugins and completions which look for Homebrew. Alsö, use `$OSTYPE` instead of calling external `uname` binary.
Check if `brew` is installed every time, and *unset* `$BASH_IT_HOMEBREW_PREFIX` if not found. This accounts for the edge-case of a user _uninstalling_ Homebrew without restarting the shell.
Member
|
well done @gaelicWizard 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New function
_bash_it_homebrew_check()sets global variable$BASH_IT_HOMEBREW_PREFIXusingbrew --prefixifbrewexists as a valid command. Ifbrewisn't installed, then return failure.Plugins can test for
brewby calling this function and, if it succeeds, they can rely on$BASH_IT_HOMEBREW_PREFIXbeing defined properly.Motivation and Context
I already started looking at this before seeing that my PR fixes #1576. This is part of a patchset to reduce external binary invocations during shell startup. This patch doesn't actually call this function anywhere, on purpose. I don't want to load
rubyif none of the user's plugins need it.How Has This Been Tested?
Tested locally.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.