Support multiple versions of _Bash Completion_#1915
Merged
NoahGorny merged 2 commits intoBash-it:masterfrom Sep 7, 2021
Merged
Support multiple versions of _Bash Completion_#1915NoahGorny merged 2 commits intoBash-it:masterfrom
NoahGorny merged 2 commits intoBash-it:masterfrom
Conversation
NoahGorny
reviewed
Aug 14, 2021
gaelicWizard
force-pushed
the
bash_completion
branch
from
da2e66b to
a521b60
Compare
gaelicWizard
force-pushed
the
bash_completion
branch
from
8f8e122 to
94f1c37
Compare
Contributor
Author
|
I've rebased on current master. |
gaelicWizard
force-pushed
the
bash_completion
branch
3 times, most recently
from
d163de5 to
21751d9
Compare
NoahGorny
approved these changes
Aug 31, 2021
Member
NoahGorny
left a comment
NoahGorny
left a comment
There was a problem hiding this comment.
Looks great!
I will let others chime in if they want to 😄
For Homebrew, switch between v1 and v2 of bash-completion based on whether the running Bash shell is new enough to use v2.
gaelicWizard
force-pushed
the
bash_completion
branch
from
21751d9 to
feacd56
Compare
Contributor
Author
|
Rebased on current master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Mac OS X, where Bash as shipped is version 3.2, support loading Bash Completion version 1 or version 2 from Homebrew based on the version of the Bash shell in operation. E.g., if we're running Bash v4+, then source Bash Completion from /usr/local/opt/bash-completion@2/etc/profile.d/bash_completion.sh, but if we're running the built-in Bash v3.2, then source from /usr/local/opt/bash-completion@1/etc/bash_completion.
Motivation and Context
I want to install Bash from [Homebrew], but I alsö don't want to.
How Has This Been Tested?
Tested locally and CI passes.
Types of changes
...more of an optimization...
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.