Skip to content

Implement Context::GetCanvas #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Implement Context::GetCanvas #1488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d4e7e3
GetCanvas
hwarmington Mar 26, 2025
f572011
external ptr
CedricGuillemet Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Polyfills/Canvas/Source/Context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,6 +961,6 @@ namespace Babylon::Polyfills::Internal

Napi::Value Context::GetCanvas(const Napi::CallbackInfo& info)
{
throw Napi::Error::New(info.Env(), "not implemented");
return m_canvas->Value();
Copy link
Contributor

@CedricGuillemet CedricGuillemet Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This returns NULL value and this code:

return Napi::Pointer<NativeCanvas>::Create(info.Env(), m_canvas);

returns an object that doesn't support getContext.
I tried to do a loop back like this in exprience.js :

context = context.canvas.getContext();

Any idea @bghgary ?

Copy link
Contributor

@bghgary bghgary Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping me offline.

Copy link
Contributor

@CedricGuillemet CedricGuillemet Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After chatting with Gary, there are a few changes needed in Canvas/Context to make it more robust. I can take care of these changes.

}
}