Implement Context::GetCanvas #1488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polyfills/Canvas/Source/Context.cpp
Outdated
| Napi::Value Context::GetCanvas(const Napi::CallbackInfo& info) | ||
| { | ||
| throw Napi::Error::New(info.Env(), "not implemented"); | ||
| return m_canvas->Value(); |
Contributor
There was a problem hiding this comment.
This returns NULL value and this code:
return Napi::Pointer<NativeCanvas>::Create(info.Env(), m_canvas);
returns an object that doesn't support getContext.
I tried to do a loop back like this in exprience.js :
context = context.canvas.getContext();
Any idea @bghgary ?
Contributor
There was a problem hiding this comment.
After chatting with Gary, there are a few changes needed in Canvas/Context to make it more robust. I can take care of these changes.
Merged
Contributor
|
Replacement PR : #1491 . Closing. |
CedricGuillemet
added a commit
that referenced
this pull request
Apr 4, 2025
Replaces #1488 - Fix wrongly named `CreateInstance` with `Initialize` - Canvas/Context unit test - Implement `GetCanvas` - Fix parameters and objectReference between Canvas and Context - Keep and return the object reference created with `getContext` - Install specified CMake version for Windows platform (see #1492 ) - Update to Babylon.js 8.0 --------- Co-authored-by: Sergio R. Z. Masson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.