Conversation
…cription Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
…nsion properties Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make CredentialDescription and Abstractions AOT-compatible with extension properties
Make CredentialDescription AOT-compatible via C# 15 extension properties
Feb 2, 2026
jmprieur
reviewed
Feb 3, 2026
src/Microsoft.Identity.Abstractions/ApplicationOptions/CredentialDescription.cs
Show resolved
Hide resolved
Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
Contributor
Author
Addressed all feedback in commit 3b6093a:
Regarding the major version: the changelog shows we're already at version 10.0.0, which is a major bump from 9.x. The changes are in the 10.0.0 section. Should we bump to 11.0.0 instead? |
Copilot
AI
changed the title
Make CredentialDescription AOT-compatible via C# 15 extension properties
Make CredentialDescription AOT-compatible via C# 14 extension properties
Feb 3, 2026
jmprieur
reviewed
Feb 3, 2026
Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
Copilot
AI
changed the title
Make CredentialDescription AOT-compatible via C# 14 extension properties
Make CredentialDescription AOT-compatible via C# 14 extension properties (v11.0.0)
Feb 3, 2026
bgavrilMS
reviewed
Feb 3, 2026
src/Microsoft.Identity.Abstractions/ApplicationOptions/CredentialDescription.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 3, 2026
src/Microsoft.Identity.Abstractions/ApplicationOptions/CredentialDescription.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 3, 2026
src/Microsoft.Identity.Abstractions/ApplicationOptions/CredentialDescription.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 3, 2026
src/Microsoft.Identity.Abstractions/ApplicationOptions/CredentialDescription.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 3, 2026
src/Microsoft.Identity.Abstractions/ApplicationOptions/CredentialDescriptionExtensions.cs
Outdated
Show resolved
Hide resolved
cpp11nullptr
reviewed
Feb 3, 2026
cpp11nullptr
approved these changes
Feb 3, 2026
…, clarify docs Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
…age limitation Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
…y library design Co-authored-by: jmprieur <13203188+jmprieur@users.noreply.github.com>
7 tasks
bgavrilMS
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AOT/NativeAOT Compatibility for CredentialDescription (.NET 10+) - v11.0.0
✅ Implementation Complete - All Feedback Addressed
📊 Implementation
Core Changes:
CredentialDescription.cs- Conditional compilation, protected internal methodsCredentialDescriptionExtensions.cs- C# 14 extension properties (.NET 10+ by design)Directory.Build.props- LangVersion 14, Version 11.0.0PublicAPI files- Updated for net10.0changelog.md- Breaking change documentation with troubleshootingMicrosoft.Identity.Abstractions.AotTests- AOT validation project.github/workflows/dotnetcore.yml- Automated AOT testing🎯 Design Decisions
Extension Properties Implementation:
Why Protected Internal:
base.Certificatewith extension propertiesWhy CA1024 Pragma:
Status: Ready for merge
Version: 11.0.0 | C# Version: 14+
TFMs: net10.0, net9.0, net8.0, net462, netstandard2.0/2.1
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.