Skip to content

Conversation

@andwhysoft
Copy link
Contributor

@andwhysoft andwhysoft commented Oct 23, 2025

AB#3385486

This PR adds the domainHint parameters into acquireTokenParameters and has a dependency on AzureAD/microsoft-authentication-library-common-for-android#2792

DomainHint is added the SDK to streamline developer experience for Social IdP/Custom OIDC scenarios with MSAL SDK. Today developer can use extraQueryParameters as a alternative which required developer to type in "domain_hint".

Copilot AI review requested due to automatic review settings October 23, 2025 14:07
@andwhysoft andwhysoft requested review from a team as code owners October 23, 2025 14:07
@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@github-actions github-actions bot added the msal label Oct 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds domainHint parameter support to AcquireTokenParameters to simplify developer experience when working with Social IdP/Custom OIDC scenarios. Instead of using extraQueryParameters to manually specify "domain_hint", developers can now use the dedicated withDomainHint() builder method.

Key Changes:

  • Added domainHint field and corresponding getter/setter methods to AcquireTokenParameters
  • Extended the builder pattern with withDomainHint() method
  • Integrated domain hint into the interactive token command parameters flow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
AcquireTokenParameters.java Adds mDomainHint field, getter/setter methods, and builder method withDomainHint()
CommandParametersAdapter.java Integrates domain hint into interactive token command parameters through getDomainHint() helper method

@melissaahn
Copy link
Contributor

Might it be helpful to add a domain hint field within msalTestApp as well?

@github-actions github-actions bot changed the title Add domainHint support to acquireTokenParameters Add domainHint support to acquireTokenParameters, Fixes AB#3385486 Oct 27, 2025
@andwhysoft
Copy link
Contributor Author

Might it be helpful to add a domain hint field within msalTestApp as well?

This is in the sense of a sample app? It will be added later.

@andwhysoft andwhysoft merged commit 76f578a into dev Oct 29, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants