-
Notifications
You must be signed in to change notification settings - Fork 137
Add domainHint support to acquireTokenParameters, Fixes AB#3385486 #2392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds domainHint parameter support to AcquireTokenParameters to simplify developer experience when working with Social IdP/Custom OIDC scenarios. Instead of using extraQueryParameters to manually specify "domain_hint", developers can now use the dedicated withDomainHint() builder method.
Key Changes:
- Added
domainHintfield and corresponding getter/setter methods toAcquireTokenParameters - Extended the builder pattern with
withDomainHint()method - Integrated domain hint into the interactive token command parameters flow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
AcquireTokenParameters.java |
Adds mDomainHint field, getter/setter methods, and builder method withDomainHint() |
CommandParametersAdapter.java |
Integrates domain hint into interactive token command parameters through getDomainHint() helper method |
msal/src/main/java/com/microsoft/identity/client/AcquireTokenParameters.java
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/client/AcquireTokenParameters.java
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/client/AcquireTokenParameters.java
Show resolved
Hide resolved
|
Might it be helpful to add a domain hint field within msalTestApp as well? |
This is in the sense of a sample app? It will be added later. |
AB#3385486
This PR adds the domainHint parameters into acquireTokenParameters and has a dependency on AzureAD/microsoft-authentication-library-common-for-android#2792
DomainHint is added the SDK to streamline developer experience for Social IdP/Custom OIDC scenarios with MSAL SDK. Today developer can use extraQueryParameters as a alternative which required developer to type in "domain_hint".