Add domainHint support to authorization request, Fixes AB#3385486 #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds native support for the domain_hint parameter in Microsoft authorization requests, streamlining the developer experience for Social IdP/Custom OIDC scenarios. Previously, developers had to manually specify this parameter using extraQueryParameters.
Key changes:
- Added
domainHintfield toMicrosoftAuthorizationRequestandTokenCommandParameters - Updated authorization request builder to accept and pass through domain hints
- Added test coverage for domain hint in authorization URLs
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MicrosoftAuthorizationRequest.java | Added mDomainHint field with getter/setter and serialization support |
| TokenCommandParameters.java | Added domainHint field to command parameters |
| BaseController.java | Updated request builder to set domain hint from command parameters |
| MicrosoftAuthorizationRequestTest.java | Added test assertions for domain hint in generated authorization URLs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../src/main/com/microsoft/identity/common/java/commands/parameters/TokenCommandParameters.java
Show resolved
Hide resolved
cacosta33
approved these changes
Oct 27, 2025
melissaahn
approved these changes
Oct 27, 2025
github-actions
bot
changed the title
mustafamizrak
approved these changes
Oct 28, 2025
andwhysoft
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
Oct 29, 2025
…2392) [AB#3385486](https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3385486) This PR adds the domainHint parameters into acquireTokenParameters and has a dependency on AzureAD/microsoft-authentication-library-common-for-android#2792 DomainHint is added the SDK to streamline developer experience for Social IdP/Custom OIDC scenarios with MSAL SDK. Today developer can use extraQueryParameters as a alternative which required developer to type in "domain_hint".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#3385486
This PR adds the domainHint support to the authorization request.
DomainHint is added the SDK to streamline developer experience for Social IdP/Custom OIDC scenarios with MSAL SDK. Today developer can use extraQueryParameters as an alternative which required developer to type in "domain_hint".