Fix start activity on android 15 and target sdk 35, Fixes AB#3326784 #2320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses layout adjustments in the StartActivity to handle Android 15 and target SDK 35 changes. The changes add a window insets listener to adjust view padding dynamically based on system bars insets.
- Added AndroidX window insets support using ViewCompat for proper layout padding
- Adapted layout behavior to prepare for upcoming Dome changes for target SDK 35
testapps/testapp/src/main/java/com/microsoft/identity/client/testapp/StartActivity.java
Show resolved
Hide resolved
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
rpdome
approved these changes
Jul 23, 2025
somalaya
force-pushed
the
somalaya/fixStartActivityScreen
branch
from
64a480b to
be96dd5
Compare
mohitc1
approved these changes
Aug 1, 2025
somalaya
changed the title
|
✅ Work item link check complete. Description contains link AB#3326784 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3326784 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, I fixed the sign in screen on Android 15 when target SDK is 35 AzureAD/microsoft-authentication-library-common-for-android#2665
Making similar changes to StartActivity as well to be ready when Dome makes changes for targetSDK 35
Fixes AB#3326784