Fixing the sign in screens when edge to edge is enabled, Fixes AB#3293334 #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
somalaya
changed the title
|
✅ Work item link check complete. Description contains link AB#3293334 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3293334 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the sign-in screen layout issue on Android 15 devices by applying system bar insets to the UI screens when edge-to-edge mode is enabled. Key changes include:
- Introducing a new flight flag (ENABLE_HANDLING_FOR_EDGE_TO_EDGE) to control edge-to-edge UI handling.
- Updating DualScreenActivity to apply window insets as padding.
- Adding the androidx core dependency in build.gradle for proper window inset support.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java | Added new flight flag for edge-to-edge UI handling. |
| common/src/main/java/com/microsoft/identity/common/internal/ui/DualScreenActivity.java | Applied system bar insets as padding for edge-to-edge mode. |
| common/build.gradle | Introduced a dependency on androidx core for window insets. |
Comments suppressed due to low confidence (1)
common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java:127
- [nitpick] The enum variable name includes 'FOR' (ENABLE_HANDLING_FOR_EDGE_TO_EDGE) while its key string does not. Consider aligning the key name to 'EnableHandlingForEdgeToEdge' for consistency.
ENABLE_HANDLING_FOR_EDGE_TO_EDGE("EnableHandlingEdgeToEdge", true);
common/src/main/java/com/microsoft/identity/common/internal/ui/DualScreenActivity.java
Outdated
Show resolved
Hide resolved
melissaahn
approved these changes
Jun 6, 2025
common/src/main/java/com/microsoft/identity/common/internal/ui/DualScreenActivity.java
Outdated
Show resolved
Hide resolved
rpdome
reviewed
Jun 10, 2025
rpdome
approved these changes
Jun 10, 2025
somalaya
force-pushed
the
somalaya/EdgeToEdgeBugFix
branch
from
448621e to
1183238
Compare
rpdome
approved these changes
Jun 13, 2025
rpdome
approved these changes
Jun 13, 2025
somalaya
added a commit
to AzureAD/android-complete
that referenced
this pull request
Jun 13, 2025
somalaya
added
the
No-Changelog
This was referenced Jun 13, 2025
Merged
somalaya
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
Jun 13, 2025
common/src/main/java/com/microsoft/identity/common/internal/ui/DualScreenActivity.java
Show resolved
Hide resolved
somalaya
added
Skip-Consumers-Check
rpdome
approved these changes
Jun 17, 2025
somalaya
added a commit
that referenced
this pull request
Jun 30, 2025
…#2690) The fix I did in this PR is flighted #2665 But we cannot control flighting when no broker is installed. I have checked with OneAuth team and they are ok with just turning this fix ON for brokered flow since that is the majority case. Fix : Simply limit the fix to brokered flow by setting the default flight value in common to false and in broker to true. See broker PR : AzureAD/ad-accounts-for-android#3130 Fixes [AB#3293334](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3293334)
somalaya
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
Aug 1, 2025
…2320) In a previous PR, I fixed the sign in screen on Android 15 when target SDK is 35 AzureAD/microsoft-authentication-library-common-for-android#2665 Making similar changes to StartActivity as well to be ready when Dome makes changes for targetSDK 35 Fixes [AB#3326784](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3326784) --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Auth password page on LTW is edge-to-edge by default on devices running Android 15 if the app is targeting Android 15 (API level 35). Please refer to this for more details. Because of this feature enabled by default, I am seeing below cropped screen.
Attached screenshot below.
Steps to reproduce:
set targetSdkVersion to 35 in BrokerHost app
launch MsalTestApp
click on Sign in button
See that the page is cropped on the top
Expected Behavior:
Should not be cropped
Fix : Adding padding in the activity showing the UI screens by getting the insets of the system bar as suggested in the edge to edge documentation.
This is after fixing the issue
Fixes AB#3293334