Skip to content

Updated ECN configuration test to reference the correct WRED profile to AZURE #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AharonMalkin wants to merge 1 commit into from
Closed

Updated ECN configuration test to reference the correct WRED profile to AZURE #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/generic_config_updater/test_ecn_config_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def test_ecn_config_updates(duthost, ensure_dut_readiness, configdb_field, opera

json_patch = list()
values = list()
ecn_data = duthost.shell('sonic-db-cli CONFIG_DB hgetall "WRED_PROFILE|AZURE_LOSSLESS"')['stdout']
ecn_data = duthost.shell('sonic-db-cli CONFIG_DB hgetall "WRED_PROFILE|AZURE"')['stdout']
Copy link
Copy Markdown
Contributor

@r12f r12f Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kperumalbfn , I don't feel this will be the right solution, because we are going to have 3 queues, so this test will not work even with this change. Do you mind to help see how to update this test to support these changes?

Copy link
Copy Markdown

@kperumalbfn kperumalbfn Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AharonMalkin This will break existing lossless WRED configs. Could you change this to get the per-queue configs from config-db to validate?

ecn_data = ast.literal_eval(ecn_data)
for field in configdb_field.split(','):
value = int(ecn_data[field]) + 1
Expand Down