Updated ECN configuration test to reference the correct WRED profile to AZURE#187
Closed
AharonMalkin wants to merge 1 commit intoAzure:202412from
Closed
Updated ECN configuration test to reference the correct WRED profile to AZURE#187AharonMalkin wants to merge 1 commit intoAzure:202412from
AharonMalkin wants to merge 1 commit intoAzure:202412from
Conversation
Author
|
@r12f please review |
AharonMalkin
changed the title
r12f
reviewed
Apr 10, 2025
| json_patch = list() | ||
| values = list() | ||
| ecn_data = duthost.shell('sonic-db-cli CONFIG_DB hgetall "WRED_PROFILE|AZURE_LOSSLESS"')['stdout'] | ||
| ecn_data = duthost.shell('sonic-db-cli CONFIG_DB hgetall "WRED_PROFILE|AZURE"')['stdout'] |
Contributor
There was a problem hiding this comment.
Hi @kperumalbfn , I don't feel this will be the right solution, because we are going to have 3 queues, so this test will not work even with this change. Do you mind to help see how to update this test to support these changes?
There was a problem hiding this comment.
@AharonMalkin This will break existing lossless WRED configs. Could you change this to get the per-queue configs from config-db to validate?
Contributor
|
Closing in favor of sonic-net/sonic-mgmt#19246 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Updated ECN configuration test to reference the correct WRED profile for Azure. Changed path from "AZURE_LOSSLESS" profile to "AZURE" to comply with changes.
Type of change
Back port request
Approach
What is the motivation for this PR?
AZURE_LOSSLESS profile is not relevant for specific SKUs and the updated profile is AZURE.
How did you do it?
changed the profile name
How did you verify/test it?
ran the test with the AZURE profile.
Any platform specific information?
sn5600/sn5640 only with specific SKUs.
Supported testbed topology if it's a new test case?
Documentation