[yang] syslog yang model by arlakshm · Pull Request #9265 · sonic-net/sonic-buildimage

arlakshm · 2021-11-15T20:05:35Z

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com

Why I did it

Add yang model for syslog server

How I did it

Add new file sonic-syslog.yang and new files for tests

How to verify it

Compile target/python-wheels/sonic_yang_mgmt-1.0-py3-none-any.whl

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

src/sonic-yang-models/yang-models/sonic-syslog.yang

wen587 · 2021-11-18T07:35:20Z

Hi, could you add a NEG_TEST for invalid IPv4 address such as 1000.0.0.5
I tested locally but I don't know why it doesn't block invalid IPv4 address.

src/sonic-yang-models/tests/yang_model_tests/tests_config/syslog.json

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

src/sonic-yang-models/tests/yang_model_tests/tests_config/syslog.json

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm · 2021-11-25T05:51:35Z

Hi, could you add a NEG_TEST for invalid IPv4 address such as 1000.0.0.5 I tested locally but I don't know why it doesn't block invalid IPv4 address.

@wen587, I have updated the constraint and test in the latest commit.

wen587 · 2021-11-25T12:25:54Z

Hi @arlakshm , thanks for the update.
Is it possible to support ipv6 syslog server in yang? Seems config syslog add does support ipv6 server.

arlakshm · 2021-11-30T18:45:55Z

Seems config syslog add does support ipv6 server.

Hi @wen587, as far as I know we support only ipv4 syslog server. The CLI command might be missing the IP address validation ?
@qiluo-msft , @renukamanavalan can you confirm

arlakshm · 2021-11-30T18:46:31Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-11-30T18:46:43Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2021-11-30T21:59:52Z

Seems config syslog add does support ipv6 server.

Hi @wen587, as far as I know we support only ipv4 syslog server. The CLI command might be missing the IP address validation ? @qiluo-msft , @renukamanavalan can you confirm

Checking #3754, we should support ipv6 syslog server address. Otherwise it will be a bug.

In reply to: 983057725

arlakshm · 2021-12-01T15:59:41Z

Seems config syslog add does support ipv6 server.

Hi @wen587, as far as I know we support only ipv4 syslog server. The CLI command might be missing the IP address validation ? @qiluo-msft , @renukamanavalan can you confirm

Checking #3754, we should support ipv6 syslog server address. Otherwise it will be a bug.

Add support of ipv6 syslog server in the latest commit

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm · 2021-12-02T16:21:25Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-02T16:21:38Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft

LGTM. Please also check with other reviewers for active comments.

wen587

lgtm. Thanks.

arlakshm · 2021-12-03T06:04:24Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-03T06:04:35Z

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm · 2021-12-03T19:19:47Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-03T19:19:58Z

Azure Pipelines successfully started running 1 pipeline(s).

praveen-li

LGTM

Why I did it Add yang model for syslog server How I did it Add new file sonic-syslog.yang and new files for tests How to verify it Compile target/python-wheels/sonic_yang_mgmt-1.0-py3-none-any.whl Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com

syslog yang model

e620bcf

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm requested a review from lguohan as a code owner November 15, 2021 20:05

arlakshm added the YANG YANG model related changes label Nov 15, 2021

arlakshm requested a review from renukamanavalan November 16, 2021 19:44

renukamanavalan previously approved these changes Nov 17, 2021

View reviewed changes

qiluo-msft reviewed Nov 18, 2021

View reviewed changes

src/sonic-yang-models/yang-models/sonic-syslog.yang Outdated Show resolved Hide resolved

wen587 self-requested a review November 18, 2021 07:35

wen587 reviewed Nov 18, 2021

View reviewed changes

src/sonic-yang-models/tests/yang_model_tests/tests_config/syslog.json Outdated Show resolved Hide resolved

address review comments

9c30226

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

arlakshm dismissed renukamanavalan’s stale review via 9c30226 November 18, 2021 21:14

wen587 reviewed Nov 19, 2021

View reviewed changes

src/sonic-yang-models/tests/yang_model_tests/tests_config/syslog.json Outdated Show resolved Hide resolved

wen587 mentioned this pull request Nov 19, 2021

Generic Config Updater Syslog server test sonic-net/sonic-mgmt#4725

Merged

4 tasks

address review comments

792dd2c

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

Merge remote-tracking branch 'github/master' into syslog_yang

e26869c

arlakshm requested a review from qiluo-msft December 1, 2021 16:00

arlakshm added 2 commits December 1, 2021 08:11

add ipv6 syslog server

56dc42e

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

fix build issue

3bbd40f

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

qiluo-msft approved these changes Dec 2, 2021

View reviewed changes

wen587 approved these changes Dec 3, 2021

View reviewed changes

qiluo-msft requested review from dgsudharsan, ganglyu, praveen-li and rathnasabapathyv December 6, 2021 23:59

praveen-li approved these changes Dec 7, 2021

View reviewed changes

arlakshm merged commit 1509f43 into sonic-net:master Dec 7, 2021

qiluo-msft added the Request for 202111 Branch For PRs being requested for 202111 branch label Jan 5, 2022

judyjoseph added the Included in 202111 Branch label Jan 9, 2022

Conversation

arlakshm commented Nov 15, 2021

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

Uh oh!

wen587 commented Nov 18, 2021

Uh oh!

Uh oh!

Uh oh!

arlakshm commented Nov 25, 2021

Uh oh!

wen587 commented Nov 25, 2021

Uh oh!

arlakshm commented Nov 30, 2021

Uh oh!

arlakshm commented Nov 30, 2021

Uh oh!

azure-pipelines bot commented Nov 30, 2021

Uh oh!

qiluo-msft commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arlakshm commented Dec 1, 2021

Uh oh!

arlakshm commented Dec 2, 2021

Uh oh!

azure-pipelines bot commented Dec 2, 2021

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

wen587 left a comment

Choose a reason for hiding this comment

Uh oh!

arlakshm commented Dec 3, 2021

Uh oh!

azure-pipelines bot commented Dec 3, 2021

Uh oh!

arlakshm commented Dec 3, 2021

Uh oh!

azure-pipelines bot commented Dec 3, 2021

Uh oh!

praveen-li left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

qiluo-msft commented Nov 30, 2021 •

edited

Loading