Skip to content

Commit 9c30226

Browse files
committed
address review comments
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
1 parent e620bcf commit 9c30226

3 files changed

Lines changed: 17 additions & 1 deletion

File tree

src/sonic-yang-models/tests/yang_model_tests/tests/syslog.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,11 @@
1111
"desc": "LOAD SYSLOG SERVER TABLE WITH INVALID IP ADDRESS AS SYSLOG SERVER.",
1212
"eStrKey": "InvalidValue",
1313
"eStr": ["server_address"]
14+
},
15+
"SYSLOG_SERVER_INVALID_IPADDR_TEST": {
16+
"desc": "LOAD SYSLOG SERVER TABLE WITH INVALID IPv4 ADDRESS AS SYSLOG SERVER.",
17+
"eStrKey": "InvalidValue",
18+
"eStr": ["server_address"]
1419
}
20+
1521
}

src/sonic-yang-models/tests/yang_model_tests/tests_config/syslog.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,16 @@
3434
]
3535
}
3636
}
37+
},
38+
"SYSLOG_SERVER_INVALID_IPADDR_TEST" : {
39+
"sonic-syslog:sonic-syslog": {
40+
"sonic-syslog:SYSLOG_SERVER": {
41+
"SYSLOG_SERVER_LIST": [
42+
{
43+
"server_address": "1111:22:33.1"
44+
}
45+
]
46+
}
47+
}
3748
}
3849
}

src/sonic-yang-models/yang-models/sonic-syslog.yang

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ module sonic-syslog {
1616
description "SYSLOG SERVER part of config_db.json";
1717

1818
list SYSLOG_SERVER_LIST {
19-
max-elements 10;
2019
description
2120
"Number of upstream SYSLOG servers, limiting to 10";
2221

0 commit comments

Comments
 (0)