Skip to content

ndk 22.9.12#93

Merged
judyjoseph merged 1 commit intoAzure:masterfrom
jon-nokia:ndk-next
Sep 1, 2023
Merged

ndk 22.9.12#93
judyjoseph merged 1 commit intoAzure:masterfrom
jon-nokia:ndk-next

Conversation

@jon-nokia
Copy link
Contributor

@jon-nokia jon-nokia commented Aug 31, 2023

Why I did it

Optimize the missing heartbeat message. It will be logged every 30 minutes when heartbeat is missing.
The SONIC application doesn't want to reboot the linecard when it is missing the midplane heartbeat. In case the warning messages are logged more often, modify the code to log their warning in every 30 minutes.

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202205

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@jon-nokia jon-nokia marked this pull request as ready for review August 31, 2023 20:28
@jon-nokia jon-nokia requested a review from lguohan as a code owner August 31, 2023 20:28
@judyjoseph judyjoseph self-requested a review August 31, 2023 23:14
@judyjoseph
Copy link
Contributor

judyjoseph commented Aug 31, 2023 •
edited
Loading

@jon-nokia so the idea here is that after noticing and logging for the first time ( that midplane connectivity is lost ) we will wait for 30 min for the following log message.

I am referring to these syslog, Are we keeping the second log message ?

  1. syslog_msg: "Unable to reach slot $USER_SLOT (Supervisor/Lincard) via Midplane"
  2. syslog_msg: "Action set to reboot. Rebooting self"

@mlok-nokia also for comments.

@judyjoseph judyjoseph merged commit 2a86783 into Azure:master Sep 1, 2023
@mlok-nokia
Copy link
Contributor

mlok-nokia commented Sep 1, 2023 •
edited
Loading

@jon

@jon-nokia so the idea here is that after noticing and logging for the first time ( that midplane connectivity is lost ) we will wait for 30 min for the following log message.

I am referring to these syslog, Are we keeping the second log message ?

  1. syslog_msg: "Unable to reach slot $USER_SLOT (Supervisor/Lincard) via Midplane"
  2. syslog_msg: "Action set to reboot. Rebooting self"

@mlok-nokia also for comments.

@judyjoseph Yes. What you described above is correct. There is a second log message.
After the change of not to reboot the LC itself when heartbeat is missing for 60 seconds. A second log message which will be logged every 60 seconds on both Linecard and Supervisor. This version of NDK contains the change to log this second message every 30 minutes instead of 60 seconds.

Supervisor log: Aug 31 05:07:59.877189 ixre-cpm-chassis7 WARNING sr_device_mgr: Unable to reach slot 1 over 10.6.1.100 (missing count: 129)
Linecard log: Aug 30 01:48:35.587291 ixre-egl-board25 WARNING sr_device_mgr: Unable to reach CPM over 10.6.0.100 (missing count: 130).

r12f pushed a commit that referenced this pull request Dec 19, 2024
@mssonicbld
[submodule] Update submodule sonic-host-services to the latest HEAD a…
8ea34e2 
…utomatically (#20022)

#### Why I did it
src/sonic-host-services
```
* e21db16 - (HEAD -> master, origin/master, origin/HEAD) [BFD]Fix BFD blackout issue (#150) (26 hours ago) [Sudharsan Dhamal Gopalarathnam]
* 39834f2 - Password Hardening: Add support to disable expiration date (#93) (4 days ago) [davidpil2002]
```
#### How I did it
#### How to verify it
#### Description for the changelog
liushilongbuaa pushed a commit that referenced this pull request Dec 26, 2024
@mssonicbld
[submodule] Update submodule sonic-host-services to the latest HEAD a…
91f6820 
…utomatically (#20217)

#### Why I did it
src/sonic-host-services
```
* dbb063a - (HEAD -> 202405, origin/202405) [BFD]Fix BFD blackout issue (#150) (52 minutes ago) [Sudharsan Dhamal Gopalarathnam]
* 8b3fcbe - Password Hardening: Add support to disable expiration date (#93) (52 minutes ago) [davidpil2002]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jun 13, 2025
@mssonicbld
[submodule][202503] Update submodule sonic-swss to the latest HEAD au…
4ac146f 
…tomatically (#1234)

#### Why I did it
src/sonic-swss
```
* 4d3cd26 - (HEAD -> 202503, origin/202503) Merge pull request #95 from mssonicbld/sonicbld/202503-merge (21 hours ago) [mssonicbld]
* 7049ca9 - Merge branch '202412' of https://github.com/Azure/sonic-swss.msft into 202503 (23 hours ago) [Sonic Automation]
* 0cf8fb0 - SRv6: set TTL decap mode to PIPE (#93) (30 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jun 20, 2025
@mssonicbld
[submodule][202503] Update submodule sonic-platform-common to the lat…
266183d 
…est HEAD automatically (#1262)

#### Why I did it
src/sonic-platform-common
```
* 741b412 - (HEAD -> 202503, origin/202503) Merge pull request #93 from mssonicbld/sonicbld/202503-merge (21 hours ago) [mssonicbld]
* 1ebe56e - Merge branch '202412' of https://github.com/Azure/sonic-platform-common.msft into 202503 (23 hours ago) [Sonic Automation]
* 6d30299 - (origin/202412) [202412] [cmis] add read only cache decorator (#86) (34 hours ago) [Jianyue Wu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Pterosaur pushed a commit that referenced this pull request Sep 12, 2025
@mssonicbld
[submodule][202412] Update submodule sonic-gnmi to the latest HEAD au…
75c02c0 
…tomatically (#1600)

#### Why I did it
src/sonic-gnmi
```
*   64e8539 - (HEAD -> 202412, origin/202412) Merge pull request #97 from Azure/202412-dev (4 hours ago) [Zain Budhwani]
|\  
| * 0de6456 - Adapt to the new usages of arguments (#93) (6 hours ago) [Changrong Wu]
| * 0be3a77 - Remove redundant helper function toString from show_common.go (#86) (23 hours ago) [gnemuw]
| * ff54cad - Fetch arguments from path and supply getters with parsed arguments (#82) (25 hours ago) [Zain Budhwani]
| * 14660a2 - Add `show dropcounters config` (#79) (33 hours ago) [Changrong Wu]
| * 1b7b835 - Added telemetry support for the 'show queue watermark' command. (#72) (5 days ago) [mramezani95]
| * 417ebe5 - interaces description implementation (#69) (6 days ago) [Vijay Sharma]
| * d3140d8 - Implement 'show ipv6 route' command (#64) (6 days ago) [gnemuw]
| * a715f58 - Add show services (#74) (7 days ago) [Zhaoyang Zhang]
| * fe4ab1c - Fix the show headroom_pool typo (#76) (7 days ago) [Guoqiang Yuan]
| * 0277718 - Add show interface naming_mode (#73) (7 days ago) [axin]
| * 03519fe - Add show interface neighbor expected (#54) (7 days ago) [jiayuj2021]
| * f29223a - Add 'show ipv6 fib' command (#67) (7 days ago) [Guoqiang Yuan]
| * 8ae677e - Add SHOW implementation for processes (#63) (8 days ago) [yiliu4]
| * 61927f9 - [202412] Add support of 'show ipv6 link-local-mode' command (#65) (8 days ago) [cgangx]
| * 4dca30c - Add show interface flap support (#66) (8 days ago) [axin]
| * 18c276b - Add show system memory (#57) (8 days ago) [Changrong Wu]
| * 00cc010 - Add support for show interface status (#32) (8 days ago) [Changrong Wu]
| * 941b3a2 - Minor changes from VLAN Brief PR Comments (#68) (8 days ago) [Vijay Sharma]
| * af89dec - show uptime (#39) (9 days ago) [Vijay Sharma]
| * 718ffd7 - Add show ipv6 bgp network (#61) (9 days ago) [Zhaoyang Zhang]
| * 8346e29 - [202412] Add support for 'show ipv6 bgp neighbors (#58) (9 days ago) [zitingguo-ms]
| * aec577c - Add implementation for show lldp neighbors (#56) (10 days ago) [nanali-msft]
| * b561228 - Add show dropcounters counts / capabilities (#40) (13 days ago) [jiayuj2021]
| * 16d6ccc - Add support for dev branches in CodeQL analysis (13 days ago) [Zain Budhwani]
* 8e41780 - Revert "Sync 202412 dev with 202412 (#94)" (#96) (4 hours ago) [Zain Budhwani]
* c5b5383 - Sync 202412 dev with 202412 (#94) (5 hours ago) [Zain Budhwani]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Oct 10, 2025
@mssonicbld
[submodule][202506] Update submodule sonic-sairedis to the latest HEA…
fb90bb6 
…D automatically (#1715)

#### Why I did it
src/sonic-sairedis
```
* f3d4b6e9 - (HEAD -> 202506, origin/202506) Increase ZMQ buffer size to accommodate large bulk calls (#93) (2 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
bingwang-ms pushed a commit that referenced this pull request Jan 16, 2026
@mssonicbld
[submodule] Update submodule sonic-dash-ha to the latest HEAD automat…
2855448 
…ically (#23472)

#### Why I did it
src/sonic-dash-ha
```
* 3d9b38f - (HEAD -> master, origin/master, origin/HEAD) Rename disable to disabled in ha_scope table (#93) (14 hours ago) [yue-fred-gao]
* 01f9bf5 - Add semgrep static analysis tool to find security vulnerabilities. (#90) (25 hours ago) [Mai Bui]
* 4121247 - Use vnet_name from DASH_HA_GLOBAL_CONFIG to create vnet route (#92) (30 hours ago) [yue-fred-gao]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@judyjoseph judyjoseph judyjoseph approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jon-nokia @judyjoseph @mlok-nokia