Skip to content

iccpd - remove unused function#272

Merged
gechiang merged 1 commit intoAzure:masterfrom
maipbui:remove_unused_func
Mar 15, 2024
Merged

iccpd - remove unused function#272
gechiang merged 1 commit intoAzure:masterfrom
maipbui:remove_unused_func

Conversation

@maipbui
Copy link
Member

@maipbui maipbui commented Feb 29, 2024

ADO 27008034

Why I did it

set_route_by_linux_route() is not called by any function within this repo and its submodules, checked on 202106 branch and master branch

git grep --recurse-submodules "set_route_by_linux_route"
src/iccpd/src/mlacp_link_handler.c:static void set_route_by_linux_route(struct CSM* csm,
src/iccpd/src/mlacp_link_handler.c:            /*set_route_by_linux_route(csm, set_l3_local_if, 1);*/   /*add static route by linux route tool*/
src/iccpd/src/mlacp_link_handler.c:            /*set_route_by_linux_route(csm, set_l3_local_if, 0);*/    /*del static route by linux route tool*/

How I did it

Remove unused function set_route_by_linux_route()

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202305

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@maipbui maipbui requested a review from qiluo-msft February 29, 2024 20:38
@maipbui maipbui requested a review from lguohan as a code owner February 29, 2024 20:38
@maipbui maipbui marked this pull request as draft February 29, 2024 21:08
@qiluo-msft qiluo-msft requested a review from rlhui March 5, 2024 18:22
@maipbui maipbui marked this pull request as ready for review March 8, 2024 19:50
@maipbui
Copy link
Member Author

maipbui commented Mar 11, 2024

@gechiang Can we merge this PR? looks like there's no code sync from sonic-net repo.

@gechiang gechiang merged commit 6bfb85a into Azure:master Mar 15, 2024
@maipbui maipbui deleted the remove_unused_func branch March 15, 2024 19:08
bingwang-ms pushed a commit that referenced this pull request Jan 16, 2026
…utomatically (#22160)

#### Why I did it
src/sonic-host-services
```
* aa971f6 - (HEAD -> master, origin/master, origin/HEAD) Revert "[featured] fix non existing feature start (#234)" (#272) (29 hours ago) [Qi Luo]
* 04e49f8 - Add iptables rules to drop all bgp packets destined for loopback1 IP addresses in dual ToR (#262) (11 days ago) [Yawen]
* 727e21b - [Caclmgrd]Fix key error issue about acl_source_ip_map (#268) (11 days ago) [Changrong Wu]
* 4cb6b97 - Restart caclmgrd whenever catch exception in child thread or in main thread (#194) (13 days ago) [Zhaohui Sun]
* d7842aa - config_db should not mandate True and False for featured (#252) (2 weeks ago) [Brad House - NextHop]
* 70de4d1 - Fix PyGObject required version (#264) (3 weeks ago) [Qi Luo]
* 953816b - Modify cacl rules to allow incoming packets to dash-ha (#256) (3 weeks ago) [yue-fred-gao]
* 5460c29 - Improve reboot status tracking and add reboot count & method to status (#259) (3 weeks ago) [Vasundhara Volam]
* e46e36e - Update ubuntu version in azure pipeline (#260) (4 weeks ago) [Vasundhara Volam]
* 23b81f9 - Fix reboot without message (#250) (4 weeks ago) [jkmar]
* 1ee792e - Implement Download and Delete For File Service (#242) (5 weeks ago) [Dawei Huang]
* 00393e3 - [kdump-config] Update kdump default config with pre-defined value in /proc/cmdline (installer.conf) (#237) (7 weeks ago) [Marty Y. Lok]
* d028745 - [Radius] Add require_message_authenticator option to fix BlastRadius issue. (#172) (7 weeks ago) [Julian Chang]
* 8237b5d - Monitor rsyslog feature flag change and update rsyslog config by restart rsyslog-config service (#245) (8 weeks ago) [Hua Liu]
* 55cee71 - Improve Detection Logic for HALT Command in is_halt_command_running() (#247) (8 weeks ago) [Vasundhara Volam]
* 29b8be8 - [featured] fix non existing feature start (#234) (3 months ago) [Stepan Blyshchak]
* fe90cb1 - Adding support for filtering by destination IP and/or incoming interface to caclmgrd. (#195) (3 months ago) [nyanto]
* 6006e05 - caclmgrd interface rules patch 1 (#197) (3 months ago) [Nanma Purushotam]
* 3ba0c59 - Pin PyGObject to 3.50.0 (#228) (3 months ago) [cpackham-atlnz]
* 5445cf6 - Radius Access request to use configured src interface (#230) (3 months ago) [lakshmi-nexthop]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants