ndk 22.9.21 by jon-nokia · Pull Request #195 · Azure/sonic-buildimage-msft

jon-nokia · 2023-12-20T15:34:15Z

Why I did it

Modify code on the Linecard to detect if Supervisor is ungraceful reboot or removal, If BDB hardware checking is missing 3 times, Linecard will reboot itself.
Add function to handle the GRPC call to disable all SFPs which provide the capability to the linecard to disable all SFP when linecard is reboot.
Added delay to start the sr_dev_mgr on Supervisor to make sure the linecard shutdown all SFPs on the down path when both linecards and Supervisor are rebooting.
Better handling of SFP module read failure and ensure minimum time in reset on SW reset request
Added thermal logging improvement.
Modified the Supervisor to call "sudo reboot" when the reboot request is from PMON API
Fix the reboot-cause history issue which is caused by the change of determine-reboot-cause.service
Fix all-modules shutdown

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

gechiang · 2023-12-21T06:57:13Z

@jon-nokia Is there any dependency of this new NDK drop? Any other PR also needs to be picked up or this is a standalone PR?

jon-nokia · 2023-12-21T15:16:10Z

@jon-nokia Is there any dependency of this new NDK drop? Any other PR also needs to be picked up or this is a standalone PR?

It should be merged with sonic-net/sonic-buildimage#17378

gechiang · 2023-12-22T01:53:36Z

@jon-nokia Is there any dependency of this new NDK drop? Any other PR also needs to be picked up or this is a standalone PR?

It should be merged with sonic-net/sonic-buildimage#17378

Thanks @jon-nokia !
knowing that it is not possible to merge both at the same time. which one should be merged first to avoid any breakage/regression whether it be build time or run time?

judyjoseph · 2024-01-05T06:27:05Z

@jon-nokia @mlok-nokia could you update the PR summary, as we have diverged a lot from the original design.
Also please update when it is ready for review/merge

jon-nokia · 2024-01-05T15:11:53Z

@jon-nokia @mlok-nokia could you update the PR summary, as we have diverged a lot from the original design. Also please update when it is ready for review/merge

Hi @judyjoseph - PR summary has been updated and these are ready to be integrated. Thanks.

mlok-nokia · 2024-01-05T15:15:18Z

@jon-nokia @mlok-nokia could you update the PR summary, as we have diverged a lot from the original design. Also please update when it is ready for review/merge

Hi @judyjoseph - PR summary has been updated and these are ready to be integrated. Thanks.

This PR should be merged with sonic-net/sonic-buildimage#17483.

judyjoseph · 2024-01-05T17:41:41Z

@mlok-nokia "If BDB hardware checking is missing 3 times" -- what is the interval in which we check this.
So this is in addition to the 4 times check for heartbeat ( with interval of 10 sec ) ?

mlok-nokia · 2024-01-05T18:12:48Z

@mlok-nokia "If BDB hardware checking is missing 3 times" -- what is the interval in which we check this. So this is in addition to the 4 times check for heartbeat ( with interval of 10 sec
The interval is 10 seconds. The heartbeat checking and BDB check happens at the same time. When heartbeat is missing, we do the BDB checking. If Heartbeat and BDB checking failed 3 times consecutively, linecard will reboot itself.

judyjoseph · 2024-01-05T19:44:52Z

Is the default log level DEBUG ? @mlok-nokia - Changing to DEBUG in this commit https://github.com/Nokia-ION/ndk/commit/c074eef1f9f0281328ab8050fd6527014ff4fa55 ( line num: 258) will it be printable data ?

mlok-nokia · 2024-01-06T01:57:30Z

Is the default log level DEBUG ? @mlok-nokia - Changing to DEBUG in this commit Nokia-ION/ndk@c074eef ( line num: 258) will it be printable data ?

The log level is info. I think it is printable data, but it could be encoded. Let me add @snider-nokia to this message

mlok-nokia · 2024-01-06T02:18:20Z

@jon-nokia Is there any dependency of this new NDK drop? Any other PR also needs to be picked up or this is a standalone PR?

It should be merged with sonic-net/sonic-buildimage#17378

Thanks @jon-nokia ! knowing that it is not possible to merge both at the same time. which one should be merged first to avoid any breakage/regression whether it be build time or run time?

In order to functioning correctly, both are need to build in the same image. Either one is merged first won't break the build

snider-nokia · 2024-01-06T02:39:14Z

Is the default log level DEBUG ? @mlok-nokia - Changing to DEBUG in this commit Nokia-ION/ndk@c074eef ( line num: 258) will it be printable data ?

The log level is info. I think it is printable data, but it could be encoded. Let me add @snider-nokia to this message

Log level is automatically defaulted to INFO level during NDK bringup. After that time, log level DEBUG output will only be seen if NDK logging level has been subsequently raised dynamically (by operator intervention) to DEBUG level. When line 258 is hit (if logging is at DEBUG level) then the data will be printed as a string of hex bytes.

snider-nokia · 2024-01-06T02:46:12Z

@judyjoseph, With NDK version 22.9.20 we have discerned a problem in test whereby oper-up 400G interfaces are not correctly shut down at LC reboot time on the way down (that is currently not occurring until LC is on the way back up again). 100G interfaces do go down timely when LC is on the way down for reboot.

We have corrected this issue and will begin OC testing with this fix this evening (build just completed and tests will be fired up shortly). You are thus going to need NDK 22.9.21 in order to have this functionality corrected (400G interfaces forced down timely at LC reboot time).

We will generate version 22.9.21, and update this PR and #196 with said, as soon as we have verified in our testbed the above referenced behavior is corrected.

mlok-nokia · 2024-01-08T14:47:55Z

@judyjoseph We have verified the NDK 22.9.21 works fine and this PR is ready for merge. Thanks.

rlhui · 2024-01-09T07:03:06Z

also tagging @deepak-singhal0408 on this one.

…lly (#18491) #### Why I did it src/sonic-gnmi ``` * ad8850d - (HEAD -> master, origin/master, origin/HEAD) Merge pull request Azure#195 from liuh-80/dev/liuh/zmq_dpu_support (2 hours ago) [Hua Liu] * 9b2dcdb - Improve code coverage (2 days ago) [liuh-80] * a9e52de - Fix code issue (2 days ago) [liuh-80] * c2d594e - Handle remove ZMQ client error (2 days ago) [liuh-80] * 70bb2ac - Merge remote-tracking branch 'origin' into dev/liuh/zmq_dpu_support (2 days ago) [liuh-80] * 1adbee3 - Remove client when retry connect failed (3 days ago) [liuh-80] * 359459b - Update mixed_db_client.go (7 days ago) [Hua Liu] * 70352fa - Get DPU address by connecter (7 days ago) [liuh-80] * 254a29d - Fix UT (8 days ago) [liuh-80] * c1186ce - Merge with latest code (8 days ago) [liuh-80] * e4c0649 - Fix space/tab issue (8 days ago) [liuh-80] * e7fc8fc - Merge remote-tracking branch 'origin' into dev/liuh/get_dpu_address (9 days ago) [liuh-80] * 0993451 - Add DbSubscriber (9 days ago) [liuh-80] * ea5f91d - Improve code to use ConfigDBConnector (2 weeks ago) [liuh-80] * b978e4d - Merge branch 'master' into dev/liuh/get_dpu_address (2 weeks ago) [Qi Luo] * 654934f - Fix UT (3 weeks ago) [liuh-80] * cb3d12f - Fix UT (3 weeks ago) [liuh-80] * 1e2132b - Improve code coverage and fix PR comments (3 weeks ago) [liuh-80] * a34d2b5 - Fix code (4 weeks ago) [liuh-80] * 32ab774 - Fix build issue (4 weeks ago) [liuh-80] * 6862050 - Add getZmqAddress method (4 weeks ago) [liuh-80] * 17d7c4a - Fix PR comments (4 weeks ago) [liuh-80] * 39ae8fe - Fix PR comments (4 weeks ago) [liuh-80] * 628ce20 - Improve code (4 weeks ago) [liuh-80] * 5f63e1c - Add getDpuAddress method to supprot multiple DPU (4 weeks ago) [liuh-80] * 44a8071 - (origin/dev/liuh/get_dpu_address) Add getDpuAddress method (4 weeks ago) [liuh-80] ``` #### How I did it #### How to verify it #### Description for the changelog

…AD automatically (#1287) #### Why I did it src/sonic-utilities ``` * 60510a62 - (HEAD -> 202503, origin/202503) Merge pull request #195 from mssonicbld/sonicbld/202503-merge (12 hours ago) [mssonicbld] * 0b84ca85 - Merge branch '202412' of https://github.com/Azure/sonic-utilities.msft into 202503 (13 hours ago) [Sonic Automation] * d3766b10 - (origin/202412) Improved the GCU's config validation logic for the WRED_PROFILE table. (#194) (16 hours ago) [mramezani95] ``` #### How I did it #### How to verify it #### Description for the changelog

…utomatically (#22660) #### Why I did it src/sonic-host-services ``` * 0206da1 - (HEAD -> 202505, origin/202505) Revert "[featured] fix non existing feature start (#234)" (#273) (51 minutes ago) [mssonicbld] * d4d624e - Add iptables rules to drop all bgp packets destined for loopback1 IP addresses in dual ToR (#269) (10 days ago) [mssonicbld] * 93db579 - Fix PyGObject required version (#265) (2 weeks ago) [mssonicbld] * 112acad - [build] Update Azure pipeline to use Ubuntu 24.04 image (#266) (2 weeks ago) [mssonicbld] * 1ee792e - Implement Download and Delete For File Service (#242) (5 weeks ago) [Dawei Huang] * 00393e3 - [kdump-config] Update kdump default config with pre-defined value in /proc/cmdline (installer.conf) (#237) (7 weeks ago) [Marty Y. Lok] * d028745 - [Radius] Add require_message_authenticator option to fix BlastRadius issue. (#172) (7 weeks ago) [Julian Chang] * 8237b5d - Monitor rsyslog feature flag change and update rsyslog config by restart rsyslog-config service (#245) (7 weeks ago) [Hua Liu] * 55cee71 - Improve Detection Logic for HALT Command in is_halt_command_running() (#247) (8 weeks ago) [Vasundhara Volam] * 29b8be8 - [featured] fix non existing feature start (#234) (3 months ago) [Stepan Blyshchak] * fe90cb1 - Adding support for filtering by destination IP and/or incoming interface to caclmgrd. (#195) (3 months ago) [nyanto] * 6006e05 - caclmgrd interface rules patch 1 (#197) (3 months ago) [Nanma Purushotam] * 3ba0c59 - Pin PyGObject to 3.50.0 (#228) (3 months ago) [cpackham-atlnz] * 5445cf6 - Radius Access request to use configured src interface (#230) (3 months ago) [lakshmi-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog

…utomatically (#22160) #### Why I did it src/sonic-host-services ``` * aa971f6 - (HEAD -> master, origin/master, origin/HEAD) Revert "[featured] fix non existing feature start (#234)" (#272) (29 hours ago) [Qi Luo] * 04e49f8 - Add iptables rules to drop all bgp packets destined for loopback1 IP addresses in dual ToR (#262) (11 days ago) [Yawen] * 727e21b - [Caclmgrd]Fix key error issue about acl_source_ip_map (#268) (11 days ago) [Changrong Wu] * 4cb6b97 - Restart caclmgrd whenever catch exception in child thread or in main thread (#194) (13 days ago) [Zhaohui Sun] * d7842aa - config_db should not mandate True and False for featured (#252) (2 weeks ago) [Brad House - NextHop] * 70de4d1 - Fix PyGObject required version (#264) (3 weeks ago) [Qi Luo] * 953816b - Modify cacl rules to allow incoming packets to dash-ha (#256) (3 weeks ago) [yue-fred-gao] * 5460c29 - Improve reboot status tracking and add reboot count & method to status (#259) (3 weeks ago) [Vasundhara Volam] * e46e36e - Update ubuntu version in azure pipeline (#260) (4 weeks ago) [Vasundhara Volam] * 23b81f9 - Fix reboot without message (#250) (4 weeks ago) [jkmar] * 1ee792e - Implement Download and Delete For File Service (#242) (5 weeks ago) [Dawei Huang] * 00393e3 - [kdump-config] Update kdump default config with pre-defined value in /proc/cmdline (installer.conf) (#237) (7 weeks ago) [Marty Y. Lok] * d028745 - [Radius] Add require_message_authenticator option to fix BlastRadius issue. (#172) (7 weeks ago) [Julian Chang] * 8237b5d - Monitor rsyslog feature flag change and update rsyslog config by restart rsyslog-config service (#245) (8 weeks ago) [Hua Liu] * 55cee71 - Improve Detection Logic for HALT Command in is_halt_command_running() (#247) (8 weeks ago) [Vasundhara Volam] * 29b8be8 - [featured] fix non existing feature start (#234) (3 months ago) [Stepan Blyshchak] * fe90cb1 - Adding support for filtering by destination IP and/or incoming interface to caclmgrd. (#195) (3 months ago) [nyanto] * 6006e05 - caclmgrd interface rules patch 1 (#197) (3 months ago) [Nanma Purushotam] * 3ba0c59 - Pin PyGObject to 3.50.0 (#228) (3 months ago) [cpackham-atlnz] * 5445cf6 - Radius Access request to use configured src interface (#230) (3 months ago) [lakshmi-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog

…tomatically (#1949) #### Why I did it src/sonic-swss ``` * 5723e62e - (HEAD -> 202412, origin/202412) Add VLAN unknown UC flooding disablement (#195) (12 hours ago) [Changrong Wu] * 89c71e89 - move around (6 days ago) [BYGX-wcr] * bb489011 - add VLAN unknown UC flooding disablement (7 days ago) [BYGX-wcr] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Sonic Automation <sonicbld@microsoft.com>

jon-nokia requested a review from lguohan as a code owner December 20, 2023 15:34

gechiang approved these changes Dec 21, 2023

View reviewed changes

jon-nokia marked this pull request as draft January 4, 2024 19:03

jon-nokia force-pushed the ndk-next branch from d94d0a1 to 551c66f Compare January 4, 2024 19:06

jon-nokia changed the title ~~ndk 22.9.19~~ ndk 22.9.20 Jan 4, 2024

jon-nokia mentioned this pull request Jan 5, 2024

ndk 22.9.21 #196

Merged

5 tasks

jon-nokia marked this pull request as ready for review January 5, 2024 15:10

judyjoseph approved these changes Jan 6, 2024

View reviewed changes

jon-nokia force-pushed the ndk-next branch from 551c66f to 1a27a91 Compare January 6, 2024 12:04

jon-nokia changed the title ~~ndk 22.9.20~~ ndk 22.9.21 Jan 6, 2024

ndk 22.9.21

e9dec46

jon-nokia force-pushed the ndk-next branch from 1a27a91 to e9dec46 Compare January 6, 2024 12:09

judyjoseph merged commit c120bf2 into Azure:master Jan 8, 2024

Conversation

jon-nokia commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

gechiang commented Dec 21, 2023

Uh oh!

jon-nokia commented Dec 21, 2023

Uh oh!

gechiang commented Dec 22, 2023

Uh oh!

judyjoseph commented Jan 5, 2024

Uh oh!

jon-nokia commented Jan 5, 2024

Uh oh!

mlok-nokia commented Jan 5, 2024

Uh oh!

judyjoseph commented Jan 5, 2024

Uh oh!

mlok-nokia commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

judyjoseph commented Jan 5, 2024

Uh oh!

mlok-nokia commented Jan 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlok-nokia commented Jan 6, 2024

Uh oh!

snider-nokia commented Jan 6, 2024

Uh oh!

snider-nokia commented Jan 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlok-nokia commented Jan 8, 2024

Uh oh!

rlhui commented Jan 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jon-nokia commented Dec 20, 2023 •

edited

Loading

mlok-nokia commented Jan 5, 2024 •

edited

Loading

mlok-nokia commented Jan 6, 2024 •

edited

Loading

snider-nokia commented Jan 6, 2024 •

edited

Loading