Skip to content

[202405] Do not add switch_id in DEVICE_METADATA for chassis_packet. #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arlakshm merged 2 commits into from
Apr 26, 2025
Merged

[202405] Do not add switch_id in DEVICE_METADATA for chassis_packet. #1056

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbf1722
Do not add switch_id in DEVICE_METADATA for chassis_packet.
abdosi Apr 25, 2025
b66280b
Update minigraph.py
abdosi Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sonic-config-engine/minigraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2241,7 +2241,7 @@ def parse_xml(filename, platform=None, port_config_file=None, asic_name=None, hw
# #voq switch_id for asic
# switch_id = chassis_metadata.get(asic_hostname, {}).get('asic_switch_id', None)
# on Voq system each asic has a switch_id
if switch_id is not None:
if switch_id is not None and chassis_type == CHASSIS_CARD_VOQ:
Copy link
Copy Markdown
Contributor

@arlakshm arlakshm Apr 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this to chassis_type != CHASSIS_CARD_PACKET_CHASSIS? in line 2249 for fabric cards we get the switch_id from minigraph and save it for CHASSIS_CARD_FABRIC

if sub_role is not None and FRONTEND_ASIC_SUB_ROLE == sub_role:
if slot_index is not None:
switch_id = get_asic_switch_id(slot_index, asic_name)
Expand Down