[202405] Do not add switch_id in DEVICE_METADATA for chassis_packet.#1056
Merged
arlakshm merged 2 commits intoAzure:202405from Apr 26, 2025
Merged
[202405] Do not add switch_id in DEVICE_METADATA for chassis_packet.#1056arlakshm merged 2 commits intoAzure:202405from
arlakshm merged 2 commits intoAzure:202405from
Conversation
Signed-off-by: Abhishek Dosi <[email protected]>
Contributor
Author
|
@anamehra for viz. |
arlakshm
reviewed
Apr 25, 2025
src/sonic-config-engine/minigraph.py
Outdated
| # switch_id = chassis_metadata.get(asic_hostname, {}).get('asic_switch_id', None) | ||
| # on Voq system each asic has a switch_id | ||
| if switch_id is not None: | ||
| if switch_id is not None and chassis_type == CHASSIS_CARD_VOQ: |
Contributor
There was a problem hiding this comment.
can we change this to chassis_type != CHASSIS_CARD_PACKET_CHASSIS? in line 2249 for fabric cards we get the switch_id from minigraph and save it for CHASSIS_CARD_FABRIC
anamehra
approved these changes
Apr 25, 2025
Contributor
|
LGTM |
arlakshm
approved these changes
Apr 26, 2025
bingwang-ms
pushed a commit
that referenced
this pull request
Jan 16, 2026
…omatically (#23392) #### Why I did it src/sonic-swss-common ``` * fc35dd0 - (HEAD -> master, origin/master, origin/HEAD) Move SonicDbTable to sonic-dash-ha. (#1056) (3 hours ago) [dypet] * 100e2e0 - [MSTP] Schema Support (#961) (5 hours ago) [Wajahat Razi] * d7c661b - [trim]: Add Packet Trimming Drop Counters DB schema (#1055) (33 hours ago) [Nazarii Hnydyn] * 465cc1c - Add test case to verify zmq reconnect behaviour (#84) (#1052) (12 days ago) [Qi Luo] * 93af927 - Move swss-common/swss-common-testing crates from https://github.com/sonic-net/sonic-dash-ha (#1044) (13 days ago) [Qi Luo] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
Do not add switch_id in DEVICE_METADATA for chassis_packet. In OA we do not pass/switch_id for chassis-packet. But their can be other application like Debug Shell which can use it when initalizing. To keep consistency just do not add this field.
How I verify:
Before
After