Skip to content

[azopenai] Fixing tests and re-enabling relevant recordings #25728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardpark-msft merged 15 commits into from
Dec 9, 2025
Merged

[azopenai] Fixing tests and re-enabling relevant recordings #25728

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
85f543f
Token counts aren't contractual for our client, no need to test for it.
Dec 6, 2025
a6e05d1
Scrubbing a test that was testing more of the internals of the servic…
Dec 8, 2025
620dde4
Disable older-style 'completions' calls until we can find a compatibl…
Dec 8, 2025
c1ab856
Lower the bar, as more of the API isn't testable (models have been de…
Dec 8, 2025
2b8fff1
Fixing audio tests so they can be enabled again.
Dec 8, 2025
0b6d368
Another small workaround to re-enable testing.
Dec 8, 2025
487393c
Adjusting another skipped test for the service.
Dec 8, 2025
a7bdc72
Fixing RAI test to handle request level content RAI stuff as well.
Dec 8, 2025
6884983
Enabling some more tests.
Dec 8, 2025
916bf16
Updating coverage number - it's dropped quite low because this packag…
Dec 8, 2025
b226447
updating test recordings
Dec 8, 2025
6ac2530
Update tags to what's in the repo.
Dec 9, 2025
c4515ad
Fix flac name issue with audio test and recordings.
Dec 9, 2025
4b16da6
Multiple possibles for "deployment doesn't exist"
Dec 9, 2025
11ba0b8
Disable some tests for live testing - the models we use for them are …
Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions sdk/ai/azopenai/client_chat_completions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,10 @@ func TestClient_GetChatCompletions(t *testing.T) {
require.NotEmpty(t, choice.Message.Content)
require.Equal(t, "stop", choice.FinishReason)

require.Equal(t, openai.CompletionUsage{
// these change depending on which model you use. These #'s work for gpt-4, which is
// what I'm using for these tests.
CompletionTokens: 29,
PromptTokens: 42,
TotalTokens: 71,
}, openai.CompletionUsage{
CompletionTokens: resp.Usage.CompletionTokens,
PromptTokens: resp.Usage.PromptTokens,
TotalTokens: resp.Usage.TotalTokens,
})
// let's just make sure that the #'s are filled out.
require.Greater(t, resp.Usage.CompletionTokens, int64(0))
require.Greater(t, resp.Usage.PromptTokens, int64(0))
require.Greater(t, resp.Usage.TotalTokens, int64(0))
}

t.Run("AzureOpenAI", func(t *testing.T) {
Expand Down
Loading