[azopenai] Fixing tests and re-enabling relevant recordings #25728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpark-msft
requested review from
PratibhaShrivastav18,
achauhan-scc,
chlowell,
glecaros,
jhendrixMSFT and
kingernupur
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes brittle assertions that checked for exact token counts in chat completion tests. The test now validates that token usage values are populated (greater than zero) rather than matching specific values, making the tests more resilient to model changes.
Key Changes:
- Replaced exact token count assertions with checks that verify token counts are positive values
- Removed model-specific hard-coded values that could cause test failures when models change
jhendrixMSFT
approved these changes
Dec 8, 2025
Member
Author
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
December 8, 2025 20:14
…e, instead of the client.
Member
Author
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
richardpark-msft
requested review from
RickWinter and
gracewilcox
as code owners
added 9 commits
December 8, 2025 23:05
…e is now mostly models (and serde), and the majority of the code is in an external client (ie, openai-go).
Member
Author
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
richardpark-msft
changed the title
added 2 commits
December 9, 2025 01:26
…deprecated, and we don't have a replacement. We can (and will) continue to test with recordings for now, just to make sure the code is correct.
Member
Author
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jhendrixMSFT
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25727