-
Notifications
You must be signed in to change notification settings - Fork 357
[ONBOARD] Kusto Add DataExplorer Operations #21
Conversation
|
Tagging as |
b4c6766 to
9d616da
Compare
|
@joshfree PR is ready for review. |
2a9b03c to
bc4b48d
Compare
42b08f6 to
9e5538d
Compare
9e5538d to
8a2988a
Compare
|
@amih90 you beat me to it :) private async Task<ICslQueryProvider> CreateKustoQueryClient(string clusterName, string? tenant = null)
{
var credential = await GetCredential(tenant);
var subscription = await _subscriptionService.GetSubscription(clusterName, tenant);
var cluster = await GetCluster(subscription, clusterName);
if (cluster == null)
{
throw new Exception($"Cluster '{clusterName}' not found in subscription '{subscription.Id}'");
}
var uri = cluster.Data.ClusterUri.ToString() ??
throw new Exception($"Could not retrieve URI for cluster '{clusterName}'");
var connectionStringBuilder = new KustoConnectionStringBuilder(uri)
.WithAadAzureTokenCredentialsAuthentication(credential);
return KustoClientFactory.CreateCslQueryProvider(connectionStringBuilder);
} |
|
also, tagging my open issue here: #45 |
|
Had another discussion about this. Right now, the description for So, the options I see are:
I'm leaning towards (2), but (3) could be enough. I'll leave the decision to @xiangyan99 who is assigned :) |
|
On track to merge Tuesday, May 6th |
|
Live tests need to also be added to the PR /cc @hallipr |
joshfree
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Kusto support is awesome!
* Fix diagram prompting * Small change * Reminder * Fix * Remove Mermaid Encode/Decode --------- Co-authored-by: Tony Chen (DevDiv) <[email protected]>
* onboard code to cloud tools * fix source analysis errors * rename iac command (#6) * rename iac command * revert changes * update * update deployment plan template * fix comments * fix the build error and refine the plan template * refine the template * add quota group (#9) * add quota group * add unit test * update region checker return message * refactor * add unit test * update * revert * [GenerateArchitectureDiagramCommand] Fix and AKS support (#8) * init aks diagram support * fix and test * fix * prompt fix encoding issue * fix by replacing + with - * fix encoding * fix test * resolve conflicts * cspell and format * fix the iac-rules-get tool name in e2etestprompt.md * Refactor: extract prompt to md file (#10) * fix * extract prompt to md file * rename available-region-list * clean code (#11) * clean code * update * add deploy command in md and fix analyze error * Some fix according to e2e test (#12) * fix prompt for test * format * update * fix * update * update * add rules * Refactor deploy"a to project * fix test failure * Add sub command description to goup description * update description based on comment * fix live test (#13) * fix live test * update quota test * update * update cspell (#14) * force to save plan to file (#15) * update plan command description * Add PR guidance document * Add test scenarios * aot safe refactoring and update template md (#16) * aot safe refactoring * update template md * move app topology definition to resource file and update the command extension implementation * update test result - not completed * update test result * reorganize file folders (#17) * reorganize file folders * update test structure * update pipeline template * format * remove comments * fix * update the command names in md file * Add code review report for PR #626 on Deploy and Quota commands * fix the comments in code review report * remove code review doc * fix test failure * Add code review report for PR #626 addressing deploy and quota commands - Summarized findings and compliance with architectural guidelines - Documented command structure, integration issues, and AOT safety - Provided targeted recommendations and next steps for improvements - Included exhaustive merge-readiness checklist and quick quality gates snapshot - Suggested documentation deltas and compliance matrix against final recommendations * Add manual testing plan and update documentation checklist for PR #626 * update action plan and add invalid json test case * feat: Add comprehensive unit tests for quota commands (#19) - Add edge case tests for whitespace-only resource types - Add tests for mixed casing in resource types with proper case preservation - Add tests for very long resource types lists (50+ items) - Enhance test coverage for AvailabilityListCommand and CheckCommand - Ensure proper validation and error handling for edge cases * lint (#20) * Chentony/mermaid response refactor (#21) * Fix diagram prompting * Small change * Reminder * Fix * Remove Mermaid Encode/Decode --------- Co-authored-by: Tony Chen (DevDiv) <[email protected]> * fix cspell errors * Mermaid generation: Fix </br> hallucination, fix copilotmd file target, fix extension installation reminder (#22) * Fix diagram prompting * Small change * Reminder * Fix * Remove Mermaid Encode/Decode * Fix </br> hallucination, fix copilotmd file target, fix extension installation reminder --------- Co-authored-by: Tony Chen (DevDiv) <[email protected]> * feat: Add remaining work items for Deploy & Quota command areas * feat: Add test execution log section to Manual Testing Plan for Copilot prompts * Xf/updatecomm2 (#23) * add logger * Hard-coded endpoints * update GetQuotaByUrlAsync * update Error handling * update doc * HTTP usage pattern * doc * format * format * add test * update * aot check * update document * update the remaining work * fix parser (#24) * update remaining work * Adds document describing tool organization tasks * Updated organization task priorities * Add 32 character max for resource names (#25) Co-authored-by: Tony Chen (DevDiv) <[email protected]> * fix build error and comments * remove image * Update Directory.Packages.props update ARM versions * Update cspell.json fix cspell json * Update sign-and-pack.yml add YamlDotNet.dll to allow list --------- Co-authored-by: xfz11 <[email protected]> Co-authored-by: wchigit <[email protected]> Co-authored-by: Vinay Gera <[email protected]> Co-authored-by: Jon Gallant <[email protected]> Co-authored-by: Tonychen0227 <[email protected]> Co-authored-by: Tony Chen (DevDiv) <[email protected]> Co-authored-by: Wallace Breza <[email protected]>
Overview
Introduces Azure Data Explorer (Kusto) operations, including:
ListandGetfor Kusto clusters.Listdatabases,ListandSchematables within a cluster.Query,Sampleagainst databases and retrieve results.Usage
Testing
Notes