Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Conversation

@jdubois
Copy link
Contributor

@jdubois jdubois commented Apr 18, 2025

Add a Dockerfile so the project can be built and run with Docker.

@dgageot
Copy link

dgageot commented Apr 18, 2025

Works just fine, as far as I can tell

@conniey conniey moved this from Untriaged to Not Started in Azure MCP Server (OLD) Apr 22, 2025
@conniey conniey moved this from Not Started to In Progress in Azure MCP Server (OLD) Apr 22, 2025
@conniey conniey added this to the Backlog milestone Apr 22, 2025
@conniey
Copy link
Member

conniey commented Apr 22, 2025

I tried the dockerfile and I don't think it's what we want the docker image to do. We want it to start the MCP server. Running dotnet azmcp by itself ends up showing a help message because there is a CLI mode for azmcp, too.

We would want the docker image to run azmcp server start --transport sse --port {your port}. By default the port is 5008 if nothing is specified.

@jongio jongio modified the milestones: Backlog, beta-2 Apr 23, 2025
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #16 (comment)

@jdubois jdubois requested a review from a team as a code owner April 28, 2025 06:58
@jdubois jdubois requested a review from conniey April 28, 2025 06:59
@jdubois
Copy link
Contributor Author

jdubois commented Apr 28, 2025

I've added the server start --transport sse part, but there's no goal to have this run in stdio mode by default? This is the only one supported by Claude Desktop, so I'm a bit surprised.
Concerning the port, I didn't specify it, as in Docker you can map the default 5008 port to whatever you want.

@conniey
Copy link
Member

conniey commented Apr 28, 2025

I've added the server start --transport sse part, but there's no goal to have this run in stdio mode by default? This is the only one supported by Claude Desktop, so I'm a bit surprised. Concerning the port, I didn't specify it, as in Docker you can map the default 5008 port to whatever you want.

We can have it run in stdio by default. :)

@joshfree joshfree added the enhancement New feature or request label Apr 28, 2025
@joshfree joshfree assigned jdubois and unassigned conniey Apr 28, 2025
@joshfree
Copy link
Member

assigning to @jdubois while we want for the requested changes

@jdubois
Copy link
Contributor Author

jdubois commented Apr 29, 2025

@conniey I added 2 env variables, AZMCP_TRANSPORT and AZMCP_PORT so those can be parametrized by the end user, is this OK for you?

@conniey
Copy link
Member

conniey commented Apr 30, 2025

@conniey I added 2 env variables, AZMCP_TRANSPORT and AZMCP_PORT so those can be parametrized by the end user, is this OK for you?

Sorry, there has been some miscommunication. STDIO for the docker image is fine. :) The Dockerfile works great going back to the previous commit and changing:
CMD ["server", "start", "--transport", "sse"]
to
CMD ["server", "start" ]

Thank you again for your contribution!

@jdubois jdubois requested a review from a team as a code owner April 30, 2025 07:32
@jdubois
Copy link
Contributor Author

jdubois commented Apr 30, 2025

@conniey I modified the Dockerfile to have stdio by default, but kept the environment variables to easily set up the sse transport & port, and documented it. Is it fine like this?

Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@conniey
Copy link
Member

conniey commented Apr 30, 2025

This could help with #64

@conniey conniey merged commit 6b24ba3 into Azure:main Apr 30, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server (OLD) Apr 30, 2025
xfz11 added a commit to xfz11/azure-mcp that referenced this pull request Aug 6, 2025
* aot safe refactoring

* update template md
g2vinay added a commit that referenced this pull request Aug 19, 2025
* onboard code to cloud tools

* fix source analysis errors

* rename iac command (#6)

* rename iac command

* revert changes

* update

* update deployment plan template

* fix comments

* fix the build error and refine the plan template

* refine the template

* add quota group (#9)

* add quota group

* add unit test

* update region checker return message

* refactor

* add unit test

* update

* revert

* [GenerateArchitectureDiagramCommand] Fix and AKS support (#8)

* init aks diagram support

* fix and test

* fix

* prompt fix encoding issue

* fix by replacing + with -

* fix encoding

* fix test

* resolve conflicts

* cspell and format

* fix the iac-rules-get tool name in e2etestprompt.md

* Refactor: extract prompt to md file (#10)

* fix

* extract prompt to md file

* rename available-region-list

* clean code (#11)

* clean code

* update

* add deploy command in md and fix analyze error

* Some fix according to e2e test (#12)

* fix prompt for test

* format

* update

* fix

* update

* update

* add rules

* Refactor deploy&quota to project

* fix test failure

* Add sub command description to goup description

* update description based on comment

* fix live test (#13)

* fix live test

* update quota test

* update

* update cspell (#14)

* force to save plan to file (#15)

* update plan command description

* Add PR guidance document

* Add test scenarios

* aot safe refactoring and update template md (#16)

* aot safe refactoring

* update template md

* move app topology definition to resource file and update the command extension implementation

* update test result - not completed

* update test result

* reorganize file folders (#17)

* reorganize file folders

* update test structure

* update pipeline template

* format

* remove comments

* fix

* update the command names in md file

* Add code review report for PR #626 on Deploy and Quota commands

* fix the comments in code review report

* remove code review doc

* fix test failure

* Add code review report for PR #626 addressing deploy and quota commands

- Summarized findings and compliance with architectural guidelines
- Documented command structure, integration issues, and AOT safety
- Provided targeted recommendations and next steps for improvements
- Included exhaustive merge-readiness checklist and quick quality gates snapshot
- Suggested documentation deltas and compliance matrix against final recommendations

* Add manual testing plan and update documentation checklist for PR #626

* update action plan and add invalid json test case

* feat: Add comprehensive unit tests for quota commands (#19)

- Add edge case tests for whitespace-only resource types
- Add tests for mixed casing in resource types with proper case preservation
- Add tests for very long resource types lists (50+ items)
- Enhance test coverage for AvailabilityListCommand and CheckCommand
- Ensure proper validation and error handling for edge cases

* lint (#20)

* Chentony/mermaid response refactor (#21)

* Fix diagram prompting

* Small change

* Reminder

* Fix

* Remove Mermaid Encode/Decode

---------

Co-authored-by: Tony Chen (DevDiv) <[email protected]>

* fix cspell errors

* Mermaid generation: Fix </br> hallucination, fix copilotmd file target, fix extension installation reminder (#22)

* Fix diagram prompting

* Small change

* Reminder

* Fix

* Remove Mermaid Encode/Decode

* Fix </br> hallucination, fix copilotmd file target, fix extension installation reminder

---------

Co-authored-by: Tony Chen (DevDiv) <[email protected]>

* feat: Add remaining work items for Deploy & Quota command areas

* feat: Add test execution log section to Manual Testing Plan for Copilot prompts

* Xf/updatecomm2 (#23)

* add logger

* Hard-coded endpoints

* update GetQuotaByUrlAsync

* update Error handling

* update doc

* HTTP usage pattern

* doc

* format

* format

* add test

* update

* aot check

* update document

* update the remaining work

* fix parser (#24)

* update remaining work

* Adds document describing tool organization tasks

* Updated organization task priorities

* Add 32 character max for resource names (#25)

Co-authored-by: Tony Chen (DevDiv) <[email protected]>

* fix build error and comments

* remove image

* Update Directory.Packages.props

update ARM versions

* Update cspell.json

fix cspell json

* Update sign-and-pack.yml

add YamlDotNet.dll to allow list

---------

Co-authored-by: xfz11 <[email protected]>
Co-authored-by: wchigit <[email protected]>
Co-authored-by: Vinay Gera <[email protected]>
Co-authored-by: Jon Gallant <[email protected]>
Co-authored-by: Tonychen0227 <[email protected]>
Co-authored-by: Tony Chen (DevDiv) <[email protected]>
Co-authored-by: Wallace Breza <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants