Skip to content

Fix EventHubTrigger sample by setting IsBatched=false #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aishwaryabh merged 3 commits into from
Jun 14, 2023
Merged

Fix EventHubTrigger sample by setting IsBatched=false #1633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
459a9c0
Set IsBatched
liliankasem Jun 14, 2023
d4058b7
fix tests
liliankasem Jun 14, 2023
2929918
fixing test again!
aishwaryabh Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/WorkerBindingSamples/EventHubs/EventDataSamples.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void EventDataBatchFunction(
/// </summary>
[Function(nameof(EventDataWithStringPropertiesFunction))]
public void EventDataWithStringPropertiesFunction(
[EventHubTrigger("queue", Connection = "EventHubConnection")]
[EventHubTrigger("queue", Connection = "EventHubConnection", IsBatched = false)]
EventData @event, string contentType, long offset)
{
// The ContentType property and the contentType parameter are the same.
Expand Down
2 changes: 1 addition & 1 deletion test/FunctionMetadataGeneratorTests/FunctionMetadataGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ public void CardinalityManyFunctions(string functionName, string entryPoint, boo
b => ValidateTrigger(b, cardinalityMany));

AssertDictionary(extensions, new Dictionary<string, string>(){
{ "Microsoft.Azure.WebJobs.Extensions.EventHubs", "5.3.0" }
{ "Microsoft.Azure.WebJobs.Extensions.EventHubs", "5.4.0" }
});

void ValidateTrigger(ExpandoObject b, bool many)
Expand Down
66 changes: 66 additions & 0 deletions test/SdkE2ETests/Contents/WorkerBindingSamplesOutput/functions.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,72 @@
}
]
},
{
"name": "EventDataFunctions",
"scriptFile": "WorkerBindingSamples.dll",
"entryPoint": "SampleApp.EventDataSamples.EventDataFunctions",
"language": "dotnet-isolated",
"properties": {
"IsCodeless": false
},
"bindings": [
{
"name": "event",
"direction": "In",
"type": "eventHubTrigger",
"eventHubName": "queue",
"connection": "EventHubConnection",
"cardinality": "One",
"properties": {
"supportsDeferredBinding": "True"
}
}
]
},
{
"name": "EventDataBatchFunction",
"scriptFile": "WorkerBindingSamples.dll",
"entryPoint": "SampleApp.EventDataSamples.EventDataBatchFunction",
"language": "dotnet-isolated",
"properties": {
"IsCodeless": false
},
"bindings": [
{
"name": "events",
"direction": "In",
"type": "eventHubTrigger",
"eventHubName": "queue",
"connection": "EventHubConnection",
"cardinality": "Many",
"properties": {
"supportsDeferredBinding": "True"
}
}
]
},
{
"name": "EventDataWithStringPropertiesFunction",
"scriptFile": "WorkerBindingSamples.dll",
"entryPoint": "SampleApp.EventDataSamples.EventDataWithStringPropertiesFunction",
"language": "dotnet-isolated",
"properties": {
"IsCodeless": false
},
"bindings": [
{
"name": "event",
"direction": "In",
"type": "eventHubTrigger",
"eventHubName": "queue",
"connection": "EventHubConnection",
"cardinality": "One",
"properties": {
"supportsDeferredBinding": "True"
}
}
]
},
{
"name": "ServiceBusReceivedMessageFunction",
"scriptFile": "WorkerBindingSamples.dll",
Expand Down
4 changes: 3 additions & 1 deletion test/SdkE2ETests/PublishTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ private async Task RunPublishTestForSdkTypeBindings(string outputDir, string add
new Extension("CosmosDB",
"Microsoft.Azure.WebJobs.Extensions.CosmosDB.CosmosDBWebJobsStartup, Microsoft.Azure.WebJobs.Extensions.CosmosDB, Version=4.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35",
@"./.azurefunctions/Microsoft.Azure.WebJobs.Extensions.CosmosDB.dll"),
new Extension("EventHubs",
"Microsoft.Azure.WebJobs.EventHubs.EventHubsWebJobsStartup, Microsoft.Azure.WebJobs.Extensions.EventHubs, Version=5.4.0.0, Culture=neutral, PublicKeyToken=014045d636e89289",
@"./.azurefunctions/Microsoft.Azure.WebJobs.Extensions.EventHubs.dll"),
new Extension("Startup",
"Microsoft.Azure.WebJobs.Extensions.FunctionMetadataLoader.Startup, Microsoft.Azure.WebJobs.Extensions.FunctionMetadataLoader, Version=1.0.0.0, Culture=neutral, PublicKeyToken=551316b6919f366c",
@"./.azurefunctions/Microsoft.Azure.WebJobs.Extensions.FunctionMetadataLoader.dll"),
Expand All @@ -146,7 +149,6 @@ private async Task RunPublishTestForSdkTypeBindings(string outputDir, string add
TestUtility.ValidateFunctionsMetadata(functionsMetadataPath, "Microsoft.Azure.Functions.SdkE2ETests.Contents.WorkerBindingSamplesOutput.functions.metadata");
}


private class Extension
{
public Extension(string name, string typeName, string hintPath)
Expand Down