Fix EventHubTrigger sample by setting IsBatched=false #1633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishwaryabh
approved these changes
Jun 14, 2023
liliankasem
added a commit
that referenced
this pull request
Jun 21, 2023
* Set IsBatched * fix tests * fixing test again! --------- Co-authored-by: Aishwarya Bhandari <[email protected]>
liliankasem
added a commit
that referenced
this pull request
Jun 22, 2023
* Set IsBatched * fix tests * fixing test again! --------- Co-authored-by: Aishwarya Bhandari <[email protected]>
liliankasem
added a commit
that referenced
this pull request
Jul 21, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 24, 2023
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-functions-dotnet-worker
that referenced
this pull request
Oct 4, 2023
* Set IsBatched * fix tests * fixing test again! --------- Co-authored-by: Aishwarya Bhandari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample project does not build as the function
EventDataWithStringPropertiesFunctionis in error:Failed to generate function metadata from WorkerBindingSamples.dll: Failed to generate metadata for function 'EventDataWithStringPropertiesFunction' (method 'System.Void SampleApp.EventDataSamples::EventDataWithStringPropertiesFunction(Azure.Messaging.EventHubs.EventData,System.String,System.Int64)'): Function is configured to process events in batches but parameter type is not iterable. Change parameter named 'event' to be an IEnumerable type or set 'IsBatched' to false on your 'EventHubTrigger' attribute. [/Users/likasem/source/functions/azure-functions-dotnet-worker/samples/WorkerBindingSamples/WorkerBindingSamples.csproj]Setting IsBatched = false on that sample to fix this issue.
Also fixing failed tests.