chore(ci): Re-enable certain bb solidity ACIR tests

[vezenovm]

It isn't clear after some of the recursion cleanup in #4221 why double_verify_proof is failing the solidity verifier.

double_verify_proof was being used as a recursive proof itself to be verified inside of double_verify_nested_proof. I have renamed this test to double_verify_proof_recursive to note that its proof should be used as input to another circuit.

I have also included a new test double_verify_proof where we accept two non-nested proofs and use the Keccak prover. This is what we were previously expecting for double_verify_proof. I also brought back arretenberg-acir-tests-bb-sol for a few tests.

[vezenovm]

@ludamad I added this back to the CI. However, I only run a few tests (one basic test and the two recursive aggregation tests).

[Maddiaa0]

#5085

Needs to add this to the circle ci definition

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 107 (+901%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 507c374b and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,276	239,396	469,856
l1_rollup_execution_gas	673,739	980,217	1,388,630
l2_block_processing_time_in_ms	1,189	4,541 (+1%)	8,970
note_successful_decrypting_time_in_ms	197 (-3%)	542	985
note_trial_decrypting_time_in_ms	⚠️ 107 (+901%)	61.7 (+1%)	119 (+1%)
l2_block_building_time_in_ms	12,070 (+1%)	47,895 (+1%)	95,679
l2_block_rollup_simulation_time_in_ms	7,315	29,315 (+1%)	58,674 (-1%)
l2_block_public_tx_process_time_in_ms	4,726 (+1%)	18,507 (+1%)	36,886

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,488 (-3%)	27,434 (+3%)
note_history_successful_decrypting_time_in_ms	1,242 (+1%)	2,432 (+1%)
note_history_trial_decrypting_time_in_ms	91.4 (+13%)	134 (-8%)
node_database_size_in_bytes	18,780,240	35,504,208
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	252	44,736	28,001
private-kernel-ordering	195	52,625	14,627
base-rollup	658 (+1%)	177,932	997
root-rollup	68.8	4,320	825
private-kernel-inner	318 (-1%)	73,715	28,001
public-kernel-app-logic	164	34,920	27,972
public-kernel-tail	81.8	34,507	27,972
merge-rollup	8.50 (-9%)	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.79	10.1 (-1%)	14.0 (-17%)	16.1 (-3%)	22.4 (+1%)	35.5	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.568	0.565 (-1%)	0.593 (-17%)	0.498 (-3%)	0.468 (+1%)	0.444 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	45.8 (-2%)	72.1 (-5%)	231	443 (-1%)	885 (+2%)	1,733
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.470 (-2%)	0.445 (-5%)	0.423	0.415 (-1%)	0.420 (+1%)	0.416
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	53.7	107 (-4%)	340	659	1,320 (+1%)	2,653 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.478	0.482 (-4%)	0.462 (+1%)	0.454	0.459 (+1%)	0.461 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.1	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.535	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,693	1,376

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	5.47 (-3%)	574

[Maddiaa0]

nice find !